From: Guenter Roeck <linux@roeck-us.net>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Wim Van Sebroeck <wim@iguana.be>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>
Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: dw_wdt: dont build for avr32
Date: Tue, 12 Apr 2016 06:06:19 -0700 [thread overview]
Message-ID: <570CF2CB.2050200@roeck-us.net> (raw)
In-Reply-To: <1460440303-20640-1-git-send-email-sudipm.mukherjee@gmail.com>
On 04/11/2016 10:51 PM, Sudip Mukherjee wrote:
> The build of avr32 allmodconfig fails with the error:
> ERROR: "__avr32_udiv64" [drivers/watchdog/kempld_wdt.ko] undefined!
>
This means there is a direct 64 bit divide operation in the driver,
which we should identify and fix.
Guenter
> Exclude this driver from the build of avr32.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>
> avr32 build log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/122158665
>
> drivers/watchdog/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index fb94765..61041ba 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -981,7 +981,7 @@ config HP_WATCHDOG
>
> config KEMPLD_WDT
> tristate "Kontron COM Watchdog Timer"
> - depends on MFD_KEMPLD
> + depends on MFD_KEMPLD && !AVR32
> select WATCHDOG_CORE
> help
> Support for the PLD watchdog on some Kontron ETX and COMexpress
>
next prev parent reply other threads:[~2016-04-12 13:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 5:51 [PATCH] watchdog: dw_wdt: dont build for avr32 Sudip Mukherjee
2016-04-12 13:06 ` Guenter Roeck [this message]
2016-04-12 13:39 ` Sudip Mukherjee
2016-04-12 14:58 ` Andy Shevchenko
2016-04-12 15:29 ` Sudip Mukherjee
2016-04-12 18:01 ` Guenter Roeck
2016-04-12 18:17 ` Andy Shevchenko
2016-04-30 18:38 ` Sudip Mukherjee
2016-05-01 0:04 ` Guenter Roeck
2016-05-01 0:36 ` Guenter Roeck
2016-05-01 1:13 ` Guenter Roeck
2016-05-01 9:04 ` Sudip Mukherjee
2016-05-01 14:09 ` Guenter Roeck
2016-05-01 16:30 ` Sudip Mukherjee
2016-04-12 13:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570CF2CB.2050200@roeck-us.net \
--to=linux@roeck-us.net \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox