From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758580AbcDLWZp (ORCPT ); Tue, 12 Apr 2016 18:25:45 -0400 Received: from mga09.intel.com ([134.134.136.24]:22339 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756565AbcDLWZn (ORCPT ); Tue, 12 Apr 2016 18:25:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,476,1455004800"; d="scan'208";a="953645367" Subject: Re: [PATCH v4 6/7] crypto: KEYS - add generic handlers to symmetric key type To: David Howells References: <20160401013819.16799.38454.stgit@tstruk-mobl1> <20160401013745.16799.91093.stgit@tstruk-mobl1> <16339.1460499046@warthog.procyon.org.uk> Cc: herbert@gondor.apana.org.au, smueller@chronox.de, linux-api@vger.kernel.org, marcel@holtmann.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, dwmw2@infradead.org, davem@davemloft.net From: Tadeusz Struk Message-ID: <570D7495.7060801@intel.com> Date: Tue, 12 Apr 2016 15:20:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <16339.1460499046@warthog.procyon.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/12/2016 03:10 PM, David Howells wrote: >> +/** >> > + * asymmetric_key_verify_signature - invoke verify signature operation on a key >> > + * of the asymmetric subtype >> > + * @key: key from the system keyring >> > + * @sig: signature to verify >> > + * >> > + * return: 0 on success or errno on failure >> > + */ >> > +int asymmetric_key_verify_signature(const struct key *key, >> > + const struct public_key_signature *sig) > This is duplicating what's in signature.c in the same directory. Right, should I remove it? Is the asymmetric_type.c good place to put all the operation handlers into? Thanks, -- TS