From: Frank Rowand <frowand.list@gmail.com>
To: frowand.list@gmail.com
Cc: Tony Lindgren <tony@atomide.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>,
Tero Kristo <t-kristo@ti.com>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH] of: Add generic handling for hardware incomplete fail state
Date: Tue, 12 Apr 2016 15:39:30 -0700 [thread overview]
Message-ID: <570D7922.5020206@gmail.com> (raw)
In-Reply-To: <570D56FE.2070408@gmail.com>
On 4/12/2016 1:13 PM, Frank Rowand wrote:
> Hi Tony,
< snip >
> With that change, the bulk of your patch looks good, with
> minor changes:
>
> __of_device_is_available() would not need to change.
>
> __of_device_is_incomplete() would change to check the new
> boolean property. (And I would suggest renaming it to
> something that conveys it is ok to power manage the
> device, but do not do anything else to the device.)
>
> -Frank
One more thought...
Are there multiple drivers that need to follow this
pattern, or just one at the moment? If just one driver,
then I would suggest open-coding accessing the property
in the probe routine instead of adding the helper
functions. If more drivers appear with the same
pattern then the helper functions could be added.
-Frank
next prev parent reply other threads:[~2016-04-12 22:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 18:37 [PATCH] of: Add generic handling for hardware incomplete fail state Tony Lindgren
2016-04-12 20:13 ` Frank Rowand
2016-04-12 20:34 ` Tony Lindgren
2016-04-12 21:41 ` Frank Rowand
2016-04-12 22:02 ` Tony Lindgren
2016-04-12 22:20 ` Rob Herring
2016-04-12 22:27 ` Tony Lindgren
2016-04-13 0:11 ` Tom Rini
2016-04-12 22:37 ` Frank Rowand
2016-04-12 22:39 ` Frank Rowand [this message]
2016-04-12 23:18 ` Tony Lindgren
2016-04-12 23:22 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D7922.5020206@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox