From: Weidong Wang <wangweidong1@huawei.com>
To: David Miller <davem@davemloft.net>, <f.fainelli@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode
Date: Wed, 13 Apr 2016 19:59:04 +0800 [thread overview]
Message-ID: <570E3488.9060403@huawei.com> (raw)
When tested the PHY SGMII Loopback,:
1.set the LOOPBACK bit,
2.set the autoneg to AUTONEG_DISABLE, it calls the
genphy_setup_forced which will clear the bit.
So just keep the LOOPBACK bit while setup forced mode.
Signed-off-by: Weidong Wang <wangweidong1@huawei.com>
---
drivers/net/phy/phy_device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index e551f3a..8da4b80 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1124,7 +1124,9 @@ static int genphy_config_advert(struct phy_device *phydev)
int genphy_setup_forced(struct phy_device *phydev)
{
int ctl = 0;
+ int val = phy_read(phydev, MII_BMCR);
+ ctl |= val & BMCR_LOOPBACK;
phydev->pause = 0;
phydev->asym_pause = 0;
-- 2.7.0
next reply other threads:[~2016-04-13 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:59 Weidong Wang [this message]
2016-04-13 14:19 ` [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode Sergei Shtylyov
2016-04-14 2:18 ` Weidong Wang
2016-04-13 18:41 ` Florian Fainelli
2016-04-14 3:42 ` Weidong Wang
2016-04-14 7:43 ` [PATCH net-next] phy: make some bits preserved " Weidong Wang
2016-04-16 0:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E3488.9060403@huawei.com \
--to=wangweidong1@huawei.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox