From: Kishon Vijay Abraham I <kishon@ti.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: <linux-rockchip@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <shawn.lin@rock-chips.com>,
<ykk@rock-chips.com>, <devicetree@vger.kernel.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>
Subject: Re: [PATCH v2 3/3] phy: rockchip-emmc: adapt binding to specifiy register offset and length
Date: Wed, 13 Apr 2016 18:31:28 +0530 [thread overview]
Message-ID: <570E4328.4050501@ti.com> (raw)
In-Reply-To: <1458854943-17388-3-git-send-email-heiko@sntech.de>
Hi,
On Friday 25 March 2016 02:59 AM, Heiko Stuebner wrote:
> The emmc-phy occupies a contiguous set of 8 registers inside the general
> register files, so the reg property should specify this.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> This is essential a counter argument for Shawn's move from reg to reg_offset
> in "phy: rockchip-emmc: fix compile issue on arm64 platform" [0].
> With the move under the grf we now also are able to specify this stuff
> cleanly using already present mechanisms.
>
> Also meant to v4.6-rc before the binding solidifies.
>
>
> [0] https://lkml.org/lkml/2016/3/8/114
>
> Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> index 461e958..555cb0f 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> @@ -4,7 +4,7 @@ Rockchip EMMC PHY
> Required properties:
> - compatible: rockchip,rk3399-emmc-phy
> - #phy-cells: must be 0
> - - reg: PHY configure reg address offset in "general
> + - reg: PHY register address offset and length in "general
> register files"
>
> Example:
> @@ -12,12 +12,14 @@ Example:
>
> grf: syscon@ff770000 {
> compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";
> + #address-cells = <1>;
> + #size-cells = <1>;
This patch is not applying. Care to resend based on linux-phy fixes?
Thanks
Kishon
next prev parent reply other threads:[~2016-04-13 13:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 21:29 [PATCH v2 1/3] phy: rockchip-dp: should be a child device of the GRF Heiko Stuebner
2016-03-24 21:29 ` [PATCH v2 2/3] phy: rockchip-emmc: " Heiko Stuebner
2016-03-25 14:51 ` Rob Herring
2016-03-29 1:53 ` Shawn Lin
2016-03-24 21:29 ` [PATCH v2 3/3] phy: rockchip-emmc: adapt binding to specifiy register offset and length Heiko Stuebner
2016-03-25 14:53 ` Rob Herring
2016-04-13 13:01 ` Kishon Vijay Abraham I [this message]
2016-04-13 13:02 ` Kishon Vijay Abraham I
2016-03-25 14:51 ` [PATCH v2 1/3] phy: rockchip-dp: should be a child device of the GRF Rob Herring
2016-03-28 11:31 ` Yakir Yang
2016-04-06 20:38 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E4328.4050501@ti.com \
--to=kishon@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox