From: Waiman Long <waiman.long@hpe.com>
To: Christoph Lameter <cl@linux.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.com>, Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Tejun Heo <tj@kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <andi@firstfloor.org>,
Dave Chinner <dchinner@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Scott J Norton <scott.norton@hpe.com>,
Douglas Hatch <doug.hatch@hpe.com>
Subject: Re: [PATCH v7 1/4] lib/percpu-list: Per-cpu list with associated per-cpu locks
Date: Wed, 13 Apr 2016 13:47:12 -0400 [thread overview]
Message-ID: <570E8620.60508@hpe.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1604131001020.3673@east.gentwo.org>
On 04/13/2016 11:03 AM, Christoph Lameter wrote:
> On Tue, 12 Apr 2016, Waiman Long wrote:
>
>> List entry insertion is strictly per cpu. List deletion, however, can
>> happen in a cpu other than the one that did the insertion. So we still
>> need lock to protect the list. Because of that, there may still be
>> a small amount of contention when deletion is being done.
> Ok then the list is not per cpu anymore. Can we call this something else
> please to avoid confusion? Spinlocks in per cpu structures are a bit
> confusing otherwise. Seems that there is no requirement that the list can
> only be accessed from a single cpu so its not per cpu per se anymore.
>
> Maybe lock-list instead of percpu-list?
>
I am fine with a name change. I am not that good in naming stuff. How
about distributed and locked list, or dlock_list in short?
Cheers,
Longman
next prev parent reply other threads:[~2016-04-13 17:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 22:54 [PATCH v7 0/4] vfs: Use per-cpu list for SB's s_inodes list Waiman Long
2016-04-12 22:54 ` [PATCH v7 1/4] lib/percpu-list: Per-cpu list with associated per-cpu locks Waiman Long
2016-04-13 2:09 ` Boqun Feng
2016-04-13 17:38 ` Waiman Long
2016-04-14 23:33 ` Boqun Feng
2016-04-15 17:14 ` Waiman Long
2016-04-13 15:03 ` Christoph Lameter
2016-04-13 17:47 ` Waiman Long [this message]
2016-04-13 18:03 ` Christoph Lameter
2016-04-14 14:10 ` Jan Kara
2016-04-14 18:48 ` Waiman Long
2016-04-12 22:54 ` [PATCH v7 2/4] fsnotify: Simplify inode iteration on umount Waiman Long
2016-04-12 22:54 ` [PATCH v7 3/4] vfs: Remove unnecessary list_for_each_entry_safe() variants Waiman Long
2016-04-12 22:54 ` [PATCH v7 4/4] vfs: Use per-cpu list for superblock's inode list Waiman Long
2016-04-14 14:20 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E8620.60508@hpe.com \
--to=waiman.long@hpe.com \
--cc=andi@firstfloor.org \
--cc=bfields@fieldses.org \
--cc=boqun.feng@gmail.com \
--cc=cl@linux.com \
--cc=dchinner@redhat.com \
--cc=doug.hatch@hpe.com \
--cc=jack@suse.com \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=scott.norton@hpe.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox