From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753168AbcDNApg (ORCPT ); Wed, 13 Apr 2016 20:45:36 -0400 Received: from seldsegrel01.sonyericsson.com ([37.139.156.29]:10996 "EHLO SELDSEGREL01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbcDNApf (ORCPT ); Wed, 13 Apr 2016 20:45:35 -0400 X-Greylist: delayed 602 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Apr 2016 20:45:35 EDT Subject: Re: [patch] ARM: qcom: silence an uninitialized variable warning To: Dan Carpenter , Arnd Bergmann References: <20160413064511.GG8092@mwanda> CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" From: Tim Bird Message-ID: <570EE5CA.5000801@sonymobile.com> Date: Wed, 13 Apr 2016 17:35:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160413064511.GG8092@mwanda> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/12/2016 11:45 PM, Dan Carpenter wrote: > It's harmless but, if "enable" isn't set, then we pass uninitialized > values to qcom_coincell_chgr_config(). The values aren't used, but > let's silence the warning anyway. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/misc/qcom-coincell.c b/drivers/misc/qcom-coincell.c > index 7b4a2da..829a61d 100644 > --- a/drivers/misc/qcom-coincell.c > +++ b/drivers/misc/qcom-coincell.c > @@ -94,7 +94,8 @@ static int qcom_coincell_probe(struct platform_device *pdev) > { > struct device_node *node = pdev->dev.of_node; > struct qcom_coincell chgr; > - u32 rset, vset; > + u32 rset = 0; > + u32 vset = 0; > bool enable; > int rc; > > Looks OK to me. Thanks for the warning cleanup! Acked-by: Tim Bird -- Tim