From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbcDNBRN (ORCPT ); Wed, 13 Apr 2016 21:17:13 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35236 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbcDNBRM (ORCPT ); Wed, 13 Apr 2016 21:17:12 -0400 Subject: Re: [PATCH v2 0/2] perf probe fixes for ppc64le To: "Naveen N. Rao" , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: Cc: Mark Wielaard , Thiago Jung Bauermann , Arnaldo Carvalho de Melo , Masami Hiramatsu , Michael Ellerman , Ananth N Mavinakayanahalli From: Balbir Singh Message-ID: <570EEF89.5080107@gmail.com> Date: Thu, 14 Apr 2016 11:16:57 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/16 19:10, Naveen N. Rao wrote: > This patchset fixes three issues found with perf probe on ppc64le: > 1. 'perf test kallsyms' failure on ppc64le (reported by Michael > Ellerman). This was due to the symbols being fixed up during symbol > table load. This is fixed in patch 2 by delaying symbol fixup until > later. > 2. perf probe function offset was being calculated from the local entry > point (LEP), which does not match user expectation when trying to look > at function disassembly output (reported by Ananth N). This is fixed for > kallsyms in patch 1 and for symbol table in patch 2. > 3. perf probe failure with kretprobe when using kallsyms. This was > failing as we were specifying an offset. This is fixed in patch 1. > > A few examples demonstrating the issues and the fix: > Given the choices, I think this makes sense Acked-by: Balbir Singh