From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753771AbcDNLMo (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Apr 2016 07:12:44 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:41672 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751752AbcDNLMm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Apr 2016 07:12:42 -0400
X-AuditID: cbfec7f5-f792a6d000001302-0b-570f7b27d691
Message-id: <570F7B26.2090202@samsung.com>
Date: Thu, 14 Apr 2016 13:12:38 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Richard Purdie <rpurdie@rpsys.net>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] leds: tca6507: silence an uninitialized variable warning
References: <20160414093616.GH16549@mwanda>
In-reply-to: <20160414093616.GH16549@mwanda>
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t/xy7rq1fzhBj1PmSxe/5vOYrH1lrTF
	5V1z2Cy2vlnHaLF711NWB1aPj09vsXjsmf+D1ePzJrkA5igum5TUnMyy1CJ9uwSujI0rEgsu
	sFW0fPzA3sC4mrWLkYNDQsBE4sc3iS5GTiBTTOLCvfVsXYxcHEICSxklFlx/wQ7hPGOU+Lv8
	JgtIFa+AlsT/+c/AbBYBVYlHj96ygdhsAoYSP1+8ZgKxRQUiJP6c3scKUS8o8WPyPbB6EQEd
	icudP8CGMgs0M0pcap/BDpIQFvCV+D/tLliDkIC2xJ0dEDYnUMOcXVfBbGYBa4mVk7YxQtjy
	EpvXvGWewCgwC8mOWUjKZiEpW8DIvIpRNLU0uaA4KT3XSK84Mbe4NC9dLzk/dxMjJHS/7mBc
	eszqEKMAB6MSD6/Get5wIdbEsuLK3EOMEhzMSiK8KpX84UK8KYmVValF+fFFpTmpxYcYpTlY
	lMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpg3NAk3SBxTl7l/PG5c1lipDZMr83de+0C28Vp
	0511801YttzIWC/KdMvkIav7rvIFblaVPKW99WXK4u9uiAj+XrW40+7lmw1yG6N9rt/l1/D4
	VSu9LLCgNNYl5Ij4xs3mS56dq8vZ1K3AG66303CRjoeOnraG3wnvTRwt20xOdM8PNVf/JbVf
	iaU4I9FQi7moOBEAelro31kCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,

Thanks for the patch.

Applied to the for-next branch of linux-leds.git.

Thanks,
Jacek Anaszewski

On 04/14/2016 11:36 AM, Dan Carpenter wrote:
> If choose_times() returns -EINVAL that means "c1" and "c2" haven't been
> initialized.  I've added a check for that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index c548ea1..45222a7 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -327,6 +327,8 @@ static void set_times(struct tca6507_chip *tca, int bank)
>   	int result;
>
>   	result = choose_times(tca->bank[bank].ontime, &c1, &c2);
> +	if (result < 0)
> +		return;
>   	dev_dbg(&tca->client->dev,
>   		"Chose on  times %d(%d) %d(%d) for %dms\n",
>   		c1, time_codes[c1],
>
>