From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Thierry Reding <treding@nvidia.com>,
devicetree <devicetree@vger.kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Daniel Kurtz <djkurtz@chromium.org>,
drinkcat@chromium.org, Dan Carpenter <dan.carpenter@oracle.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.
Date: Thu, 14 Apr 2016 16:08:43 +0200 [thread overview]
Message-ID: <570FA46B.2080706@collabora.com> (raw)
In-Reply-To: <CACvgo50ku9FZJU4YqdFsa6_=FqeDsq2UiCZkSVTLuTKsPRf7qw@mail.gmail.com>
Hi Emil,
On 14/04/16 16:06, Emil Velikov wrote:
> Hi Enric,
>
> On 14 April 2016 at 14:42, Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
>> The patch was implemented first without OR'ing error codes. The reason why I
>> changed this is because I received the comments that checking the error on
>> every regmap_* didn't help the readability of the driver and is likely to
>> not fail if the first call doesn't fail.
>>
>> For example, originally the code was like this:
>> http://pastebin.com/rPgyji8k
>> but I changed to this
>> http://pastebin.com/rPgyji8k
>>
> Both links are the same ;-) But I believe we all get what you meant.
>
Ooops, sorry. This is the other link
http://pastebin.com/e2KpGxHy
> Just a side note: many other drivers in DRM subsystem, inconsistently
> check the return value of the regmap API. Note sure how likely is any
> of it [regmap_foo] to fail and/or how determined people are to handle
> every possible error case.
>
> -Emil
>
Enric
next prev parent reply other threads:[~2016-04-14 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 12:52 [PATCH v3 0/3] Add ANX7814 I2C bridge driver Enric Balletbo i Serra
2016-04-08 12:52 ` [PATCH v3 1/3] of: Add vendor prefix for Analogix Semiconductor Enric Balletbo i Serra
2016-04-08 12:52 ` [PATCH v3 2/3] devicetree: Add ANX7814 SlimPort transmitter binding Enric Balletbo i Serra
2016-04-08 12:52 ` [PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support Enric Balletbo i Serra
2016-04-14 13:10 ` Thierry Reding
2016-04-14 13:42 ` Enric Balletbo i Serra
2016-04-14 14:06 ` Emil Velikov
2016-04-14 14:08 ` Enric Balletbo i Serra [this message]
2016-04-14 14:32 ` Thierry Reding
2016-04-18 11:23 ` Enric Balletbo i Serra
2016-04-20 12:56 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570FA46B.2080706@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).