From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932832AbcDNQAa (ORCPT ); Thu, 14 Apr 2016 12:00:30 -0400 Received: from mail-bl2on0072.outbound.protection.outlook.com ([65.55.169.72]:62496 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932644AbcDNQA2 (ORCPT ); Thu, 14 Apr 2016 12:00:28 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-5f3ff70000000be7-2d-570fbaca06cb Subject: Re: [patch] scsi_dh_alua: uninitialized variable in alua_rtpg() To: Dan Carpenter , "James E.J. Bottomley" References: <20160414093917.GA16891@mwanda> CC: "Martin K. Petersen" , Hannes Reinecke , Bart Van Assche , "Johannes Thumshirn" , Ewan Milne , , , From: Bart Van Assche Message-ID: <570FBB0E.9030902@sandisk.com> Date: Thu, 14 Apr 2016 08:45:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160414093917.GA16891@mwanda> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42JZI8azSPf0Lv5wgwmbmSxe/5vOYrFsZbTF nkWTmCxWTcyzeNw1g9Vi6y1pi8u75rBZdF/fwWax/Pg/JgdOjweHNrN4fHx6i8Xj/b6rbB6b T1d7fN4kF8AaxWWTkpqTWZZapG+XwJXRd24pa8Eajoo9Rw8zNjC+Zuti5OSQEDCRuDnzChOI LSQwl0mi7YtwFyMXkL2DUeL5rQlMMEXv9ixkgkgsZZR4/P0PI0hCWMBD4vS2a+wgtohAgsTq lwvZICZpS0z+fY8VpIFZYCuTRMuiLWANbAJGEt/ez2QBsXkFtCTuPfsDtoFFQFWi+XsHK4gt KhAhsXrdNWaIGkGJkzOfgNVzCuhIrO36DFTDATTUXuLB1jKQMLOAvMT2t3OYQXZJCDxllTgx 7wQ7xBHqEieXzGeawCg8C8moWQjts5C0L2BkXsUolpuZU5ybnlpgaKpXnJiXklmcrZecn7uJ ERI9mTsY7z7xPsQowMGoxMP7oIY/XIg1say4MvcQowQHs5IIb/w2oBBvSmJlVWpRfnxRaU5q 8SFGaQ4WJXFet3tfwoQE0hNLUrNTUwtSi2CyTBycUg2MuZ2/WMLE24w8She5u1avzDOZe3FO zSPfwneHuQ1ydnKqsPy6wWf2bAOfrcRh7bpNF/+GuO4KmrPz4v6XRuwfQgJ3Puc5OtFDy+r7 lXVpLm5PZcw8n6vEJeR/bn9p/cVr66fHfO9O32K80s2t5VX69ePt5PMz1gfczlT5OpXbLjpT /oFYYxSLEktxRqKhFnNRcSIAzQsH4JoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkluLIzCtJLcpLzFFi42Lh2siRosu3mz/c4PdGNYuDP9sYLV7/m85i sWxltMWeRZOYLFZNzLN43DWD1WLrLWmLy7vmsFl0X9/BZrH8+D8mBy6PB4c2s3h8fHqLxeP9 vqtsHtPWnGfy2Hy62uPzJrkAtigum5TUnMyy1CJ9uwSujL5zS1kL1nBU7Dl6mLGB8TVbFyMn h4SAicS7PQuZuhi5OIQEFjNKXHj6gxEkISzgIXF62zV2EFtEIEHi6MnpTCC2kIC2xOTf91hB GpgF1jNJ3NwzCayITcBI4tv7mSwgNq+AlsS9Z3/AGlgEVCWav3ewgtiiAhESq9ddY4aoEZQ4 OfMJWD2ngI7E2q7PYDXMArYSd+buZoaw5SW2v53DPIGRbxaSlllIymYhKVvAyLyKUSw3M6c4 Nz2zwNBQrzgxLyWzOFsvOT93EyM4sDkjdzA+nWh+iJGJg1OqgZHhjoZxAIcl749W/5WCzV+O fgl+uXNrwq8LmqtufKx/NG1ZwVbn29Kzfon9KZjfmJfyJlFv78n+WoMPBpNPZS9eYBK9yuv5 /IWHihi3fg1SOHSwwvZNxctPx1Yc/xImEetf/ZFBxvvZ5ZwdfwOXGF7Sl/pUeeTHAa59R+6c OdmyoPyR6jt9OZsgJZbijERDLeai4kQAGyv+FRwCAAA= X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(24454002)(189002)(377454003)(5008740100001)(19580405001)(586003)(2270400002)(189998001)(5003600100002)(6806005)(4001350100001)(1096002)(1220700001)(92566002)(54356999)(76176999)(87266999)(50986999)(4326007)(47776003)(81166005)(53416004)(33656002)(80316001)(83506001)(19580395003)(230700001)(2906002)(5001770100001)(50466002)(59896002)(65956001)(87936001)(65806001)(77096005)(86362001)(11100500001)(106466001)(65816999)(64126003)(23746002)(36756003)(2950100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0201MB1866;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD021;1:kpDNJEMtv4qKEWSe8yJ8wpzf9F/EncUaLsOY6I6daUVBCGftcwfN8LkSdC8R5Gnnxh992eSXdDk7qVneL9DAf3mNdg5Hz4MPFwG1K7ELnrTFAwA/YHn4wMbos6Pgyrt5QyXR/01FOes0esVnf+Gx8gGQS7byl1dySO0w80qIu5IBOxPk5aZ7VggdTiru2ziO9Oxm8zV/DrlgxULUODph9dn0g5NfJcuFbqGVGa0eGc+d5NsyXuD0HeSNw6M3WmZBrM1raPVyZfnh+DodQA/MZ/yuIMpsaBrG/B3SKgm63R4HKRmpQEGf/k1i1wfOYjzG10SrGmCeu2PskesrNrL9PHLdvYrX+q1DSpIjIWwQQIm64cjoGuEF21tHYqL5/vZy6i03defU8roN2+rr8Uc5Qafyn0nKcmsWc0gXkJFLflzZV9Ac5MJmGN2sdw/x89Ue X-MS-Office365-Filtering-Correlation-Id: d4333e88-dd1e-4cee-3109-08d3647bc959 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1866;2:HrtV7q2FAWBWS4SoX4uk3cH5dZjf6Uo/7NfiN+yhRr9P8RfyOoOlgKW3s2UWLDnEOYrUs6C/0NeT/Qm/d8UZD9HFab1SYyd9SpkcJAGwu2VGi8Jv0gGapurnmQ4cfbJKN3928AoyOk2us+h2mTy7PWibSEUkq6i3RrWr9zN9NBfPo/f13fWgk+pT/SYbPpzU;3:P+YDs9H4ExUqYQceHndvtBTzawDMCjt86j7heRDbApfPP1WGzOVTfKCdLrK5Thwq4b/FeL2YScKo3bOBl9qGRGeqWL2pmfbV2nCbl9cuyU6dndYYGtQTh73l3OQ4/VPQ+SkwIUjAVyMVqKdE3AdJv9lc2mXgaODf1u4ARXDhmdgmKlS1YFz201S0rAZCcP9iRtcpY1fxTZ+4BfLjqiT5R+L0x0IPGfSguBcQae+b9LkNDRk3UjpF2rTy/g46dWkVgje/dXRnVMlYa7W0R831IQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1PR0201MB1866; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1866;25:C8ezQsZvdya+wQ2p2r1kJsKXtfEl3RBvD9QvOqez5dvC17gL7Y+uEtm6+xe1izZES2Cgyhi0CKTK3C/Ew1jIkXFRWDeiVomKH1MHdRnpPILGsiBW8Y6qWJmi7HqU7c1wfZnoaXZF8ovL1QWL0wDxpjtFxWNL83qffCWzVFyCQ4XEMJHGgiR2ncxAzDydgbBTXjurc5QCShqyzNTB9/M2Zz2bzMZx54yvXyPz08iE5yvwKM1z5d63KYQnkxUKk1/HKPqaQ5o4ylZ+2tBGemOndMItVu2JJ84RpZJqW71rx5NFbpEocuu9YBQskjB4+9CsoMzcHzCOhbCKmOxWSywGBzIQcff1Cq8/YSa6C68LE35KcuqeNkF3M1CnOgt0nq+IGDu5W55iO7Mn3Z3hOqeLJrpSUA6tOWlccAUyUGHJG/5DYHtIxBysnedgEP75EmHWLjQT6ygGVy1fwDSy4n0Ri8IrbVmX+w5+hXMKrzdKT8thdw8QZtW8/Q12TOsTKOr09P87k/aIHpEKIolqZQWCmYbPiuho09Utag39Ds4XaHmV4NwnbkBrvTA2vtlYyk0fTs9uVFyiJ6hDxBPLZ9VjcR7Jvx8m/ri1ZjMu05e4eBT8eheANG/VQmrd7PIKtDOUV9YKjvJpxqBut6XnE971RdVPDMF3t5KOAoUPJWy+5VeGICnP2WWNqhP4GGAFscMY X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1866;20:QZNkDxn3hI/Ke1vi9njUckevsC0XqMcBAF4AEl/I83/71NWCuk99gql0XPedjgJ7jMig/k28CcGVIe5eky/5mYVP2EoNBf4Tr+ko8dRg+6j1XTm08E4gvo60S3Y04OGsDryL3suXjExT/PSVeHm+H6l7PsRhd45FS4gUL9OBqmiWB2mK3DrmfYhoaM8cMojtnELLYTXr2wFCNGEXRubPjIAewM6hV0aIzmRqZIixGC9KOjMTq7s5S9huepwGjCnDjwl6hFLFdKpd5036txbBPKk2/WsiI7HF/FFmfyUn3/7dADRpsJdwRvr9OKCqnTEYl9RlRB4cSZ8k2wYNKQFniHsGZQVivN2Yp//touvfmUxkS3awtT4qLDOJmU71HQezN+HZ4UNyNIUbSPfxBx90BKmo+cN4eQ4e+72xapR7x5UVBvdXOCMKU02GwrVmvgoBci4MXOVbh7rlkKJPq6D0P1jlDguNV0kg8EhulfnNpH5J1wa8Ta3QKKEncYWsSQaS;4:/61oBaJ5N7OVTL6fcPwNrSOz9aGc91MZfCV9hpO7g3gKxtoujAHYDs5HEO6UkOk5fgFJiy7iyUYL9NsBXlG6vzbUUDd/6sfIQGG961m5ue//ElZv3+eJr+kY+SDybsXmRfd2YIMbZUjIJLe1edVvfuQawpMvcdF6WM08QdXMucvOxCg62ViPe4jmUJ2VOC9Qk7duJXSdiTIrvmUKNI/fRimXvWhWyAyMZ1yiCTgH5e7OLYtOWm7Sjgsh5YaZcWKmayqm+cV3PBihe57VQjCvVEC3K0do8rOvAovYEYk5iRNIBhH1VC9C0NTDKBPkaWe0eZ2ySmmg49RnD4aMXgnEYnypihXpFlT83al5KgZnR52Q9C7mGnSOYJHYt5tvV5VEqKotzYZ7ArkxZyfXKGT1EeoMm9gQVZ2620NNUu7fedA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(10201501046)(3002001)(6055026);SRVR:CY1PR0201MB1866;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1866; X-Forefront-PRVS: 0912297777 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR0201MB1866;23:+Y4S3rt43SKbmPcFcrH76hJ2A/QqxVWST60?= =?Windows-1252?Q?a4z+BgccG+YgorqZ+Zn8C/OJPooHlt4YQYEsnRIxvvb1UUFhFTMYW5S7?= =?Windows-1252?Q?sL0+NCTGt1dfjkmAC9iWw2Eqx1bSRX6c5EhqK0/rOdNaxz3oz5q4V4Ka?= =?Windows-1252?Q?7NwxSvDRLMtmti9FyM8AwtZj+5+g9JBXXwXK47zXelLluITwLTwckYfl?= =?Windows-1252?Q?hh+eXANVYAzOWF0q18jPKkbpt9IvqC6UVQu7N+U8CBuoar+g9uLxs7dt?= =?Windows-1252?Q?gsmr8SvxTvGIPC0BCW2YKbM2ay9wTA62g1w5h8YS5G6Ugegd0lgbKRUq?= =?Windows-1252?Q?7OC2VKSwDKdKCQDojc5kN4YUi0hty8MLokGB2ezax0SF4C8eGYHG4q+p?= =?Windows-1252?Q?fVmuROE98SkK9q7RMawDctLC6WSILm6ZyT8ot/Eqman8rqupKInnPC4k?= =?Windows-1252?Q?ruJf+aoOAGKcAuydJ2YYadhC9txkN5mboc63mqgqMjtWap9qOU6LVBMp?= =?Windows-1252?Q?iGhUZekksD6YV7tIxZolhWTR/DTsxSopnzI7fKMiyQltuGxNi9vPivwz?= =?Windows-1252?Q?d7qD1IZ9NJ+IaNXeekeHZbplA3WmrdkNLE+tpoHHtT9zPlcqc7QXJhZ/?= =?Windows-1252?Q?RzQfmMvW9NLfaudLG2k6YzRFIiW8HJW7nRHkX5D9u0jutyZGSFjp4ltb?= =?Windows-1252?Q?OW41Rm3XtO4APSJ63660jQf3i0cRxI15y8tgMqfLVND++UUraYu8QiOl?= =?Windows-1252?Q?PwtX1peiTsN/lv91amw1nwi9WUFlzSppIfFqaKxw1hAhNpirucowodI9?= =?Windows-1252?Q?72qEI5+10t5laxEzjqeA2glPHItZ5C3HAYUaZkMyjbGQs1dzCsjEbaor?= =?Windows-1252?Q?UulNSUD1tKQj3gMt6/NBbLH07bFoG0k+c92xC4laI8radC308l49M/e0?= =?Windows-1252?Q?1efdyNjw2hsn/l1NKKxAffp7QIfuF8Lj5LhbhSDfN5nKvv8nUI5gyXPs?= =?Windows-1252?Q?KKk3urt5GzwQU7RVWfOzLDykAijWmxPmz3p9CMJ/3CphYMEilCEQKJAu?= =?Windows-1252?Q?ZWUdsOmAEYeyYM87P/CeGl9QCXxHp25GVniIY8FUmA5eCieUTSp5SzVM?= =?Windows-1252?Q?+pf6xCQQVDrrtglSx/tCoUZ9Nq9UENVw6kvp8kdcM9EeS+b42z7w0Goc?= =?Windows-1252?Q?2yt0RwPF3mnFa+JSXrPjNUeYw77kzFO6ZcKpnty5rBaV1XeC9SavJQPp?= =?Windows-1252?Q?YN25PVB9loszDf4HRoN78Mj4u8xt2CbKVIuD0D48mO8GrVoUbGF+T9ga?= =?Windows-1252?Q?m21NqQ45xJDwUj4BMQ2FLLDip2w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1866;5:2xUd5psz4Kd37Cu87ilPnt6soEw0Kbg+kkrGihah7+sMb9e7ztV9h7XPY4bOpW/cJcUPsFgCi5X9S71+N6NJ+22SJLE9L5MTR9B1281nrQiapuAE+cawpE54K2SbO7N4nRhdfoYwaFw06wRu41PUDjqFv9giMt8TSH2mXC74+scHfnV9l0LEi9AR5ThvELlr;24:vtP0tUeUhsxpVkz8gPwAKnVyZ1AbAg7EIHtLLlzEZ3x5rEbOxzEhruTN8KTVygFV6kBCnBk3IDTzVAWKB6YGhEkUctCqPTqWhUtWcpVgLfU=;7:wtIr6+lOkfPl8Rn8iau1ugTm7hClqruTJx3SPnpY54k72HxsISFMt8OnKySul+UrnsiCBTwJ8uOYAqIVwPyiyn7JtuOoIsp2Ik0U/tblZo4lVl4O/RhfZI89oxVvhSfs6KTa4LpCcssNR6S5yC/OZghk1nEaJlk4vohcnWhLlpo/a039WnQ5cL5feOI2GAaQFJ/kvtP5BW0UlMZk0OVVtfAjscIypTPG7bXmHEFhkrg=;20:S4uDKjyXGfyNjFP9UvSm/Rd3IDMKO9JdXK3P77/su5532SwMtGgE76QxKqt2G9AdP9X0JIpZklbXTmxzfkmo5ZZQC8qCToFVAg0atPKKSBdkXMYYYZd8a4jeNORSGml3NaGd5CZbJxq8D6UubvXTHj+m9C4SWrTZmRnJ+x/WhW0e6B+J49rOLQzqAvTHtGkCd7Ycpsh3zOAtSPlFPTsnQauCS9iEYeMukNUhDUzFFKdSpBhWpOiBU8l5QLkrsd8Q SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2016 15:45:20.2768 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1866 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2016 02:39 AM, Dan Carpenter wrote: > It's possible to use "err" without initializing it. If it happens to be > a 2 which is SCSI_DH_RETRY then that could cause a bug. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c > index 8eaed05..f3c994f 100644 > --- a/drivers/scsi/device_handler/scsi_dh_alua.c > +++ b/drivers/scsi/device_handler/scsi_dh_alua.c > @@ -513,7 +513,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg) > struct alua_port_group *tmp_pg; > int len, k, off, valid_states = 0, bufflen = ALUA_RTPG_SIZE; > unsigned char *desc, *buff; > - unsigned err, retval; > + unsigned int err = 0; > + unsigned int retval; > unsigned int tpg_desc_tbl_off; > unsigned char orig_transition_tmo; > unsigned long flags; Hello Dan, The code that uses the 'err' variable occurs in a loop. I think the initialization of 'err' should occur after the "retry:" label. Bart.