From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964831AbcDNQsl (ORCPT ); Thu, 14 Apr 2016 12:48:41 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35073 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493AbcDNQsk (ORCPT ); Thu, 14 Apr 2016 12:48:40 -0400 Subject: Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage To: Mark Brown References: <1460569154-25030-1-git-send-email-srinivas.kandagatla@linaro.org> <1460569154-25030-4-git-send-email-srinivas.kandagatla@linaro.org> <20160414064229.GC18024@sirena.org.uk> <570F8E77.5090202@linaro.org> <20160414151815.GG18024@sirena.org.uk> Cc: Greg Kroah-Hartman , Maxime Ripard , linux-kernel@vger.kernel.org, rjendra@qti.qualcomm.com From: Srinivas Kandagatla Message-ID: <570FC9E5.2050209@linaro.org> Date: Thu, 14 Apr 2016 17:48:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160414151815.GG18024@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/04/16 16:18, Mark Brown wrote: > On Thu, Apr 14, 2016 at 01:35:03PM +0100, Srinivas Kandagatla wrote: > >> I totally agree that there is an abstraction failure here in both sides. It >> should be fixed. moving to using bulk apis would solve the nvmem problem for >> now. But for long term, using regmap should be totally removed from nvmem >> and directly use the reg read/write callbacks from nvmem providers, This >> would be much robust solution. This was indeed Maxime's first proposal. I >> will try to fix it up and see how it looks without regmap. > > OK, so just replacing all the _raw_ calls with _bulk_ for now? If > you're doing that watch out for the fact that the reads come back native > endian which might upset things. Yep, that would confuse users. I think its better I do a long term solution of regmap replacement with callbacks before someone else starts reporting issues. --srini >