From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964897AbcDNRBQ (ORCPT ); Thu, 14 Apr 2016 13:01:16 -0400 Received: from foss.arm.com ([217.140.101.70]:44596 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932099AbcDNRBP (ORCPT ); Thu, 14 Apr 2016 13:01:15 -0400 Subject: Re: [PATCH V2 01/15] coresight: tmc: modifying naming convention To: Mathieu Poirier , linux-arm-kernel@lists.infradead.org References: <1460483692-25061-1-git-send-email-mathieu.poirier@linaro.org> <1460483692-25061-2-git-send-email-mathieu.poirier@linaro.org> Cc: linux-kernel@vger.kernel.org From: Suzuki K Poulose Message-ID: <570FCCD8.5060402@arm.com> Date: Thu, 14 Apr 2016 18:01:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1460483692-25061-2-git-send-email-mathieu.poirier@linaro.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/16 18:54, Mathieu Poirier wrote: > According to the TMC architectural state machine, the 'stopped' > state is reached when bit 2 (TMCReady) of the TMC Status register > turns to '1'. The code is correct but the naming convention isn't. > > The 'Triggered' bit occupies position '1' of the TMC Status register > and has nothing to do with the indication of the TMC entering the > stopped state. As such renaming function "tmc_wait_for_triggered()" > and changing the #define to reflect what the code is really doing. > > This patch has no effect other than clarifying the semantic. > > Signed-off-by: Mathieu Poirier Reviewed-by: Suzuki K Poulose Suzuki