* [PATCH v2] lib/stackdepot.c: allow the stack trace hash to be zero
@ 2016-04-13 12:07 Alexander Potapenko
2016-04-15 16:27 ` Andrey Ryabinin
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Potapenko @ 2016-04-13 12:07 UTC (permalink / raw)
To: adech.fo, dvyukov, cl, akpm, ryabinin.a.a, kcc, iamjoonsoo.kim
Cc: kasan-dev, linux-kernel, linux-mm
Do not bail out from depot_save_stack() if the stack trace has zero hash.
Initially depot_save_stack() silently dropped stack traces with zero
hashes, however there's actually no point in reserving this zero value.
Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Alexander Potapenko <glider@google.com>
---
lib/stackdepot.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 654c9d8..9e0b031 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -210,10 +210,6 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace,
goto fast_exit;
hash = hash_stack(trace->entries, trace->nr_entries);
- /* Bad luck, we won't store this stack. */
- if (hash == 0)
- goto exit;
-
bucket = &stack_table[hash & STACK_HASH_MASK];
/*
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] lib/stackdepot.c: allow the stack trace hash to be zero
2016-04-13 12:07 [PATCH v2] lib/stackdepot.c: allow the stack trace hash to be zero Alexander Potapenko
@ 2016-04-15 16:27 ` Andrey Ryabinin
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Ryabinin @ 2016-04-15 16:27 UTC (permalink / raw)
To: Alexander Potapenko, adech.fo, dvyukov, cl, akpm, kcc,
iamjoonsoo.kim
Cc: kasan-dev, linux-kernel, linux-mm
On 04/13/2016 03:07 PM, Alexander Potapenko wrote:
> Do not bail out from depot_save_stack() if the stack trace has zero hash.
> Initially depot_save_stack() silently dropped stack traces with zero
> hashes, however there's actually no point in reserving this zero value.
>
> Reported-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Signed-off-by: Alexander Potapenko <glider@google.com>
Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> ---
> lib/stackdepot.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/lib/stackdepot.c b/lib/stackdepot.c
> index 654c9d8..9e0b031 100644
> --- a/lib/stackdepot.c
> +++ b/lib/stackdepot.c
> @@ -210,10 +210,6 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace,
> goto fast_exit;
>
> hash = hash_stack(trace->entries, trace->nr_entries);
> - /* Bad luck, we won't store this stack. */
> - if (hash == 0)
> - goto exit;
> -
> bucket = &stack_table[hash & STACK_HASH_MASK];
>
> /*
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-15 16:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-13 12:07 [PATCH v2] lib/stackdepot.c: allow the stack trace hash to be zero Alexander Potapenko
2016-04-15 16:27 ` Andrey Ryabinin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox