From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbcDORlV (ORCPT ); Fri, 15 Apr 2016 13:41:21 -0400 Received: from foss.arm.com ([217.140.101.70]:51808 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916AbcDORlU (ORCPT ); Fri, 15 Apr 2016 13:41:20 -0400 Subject: Re: [PATCH V2 03/15] coresight: tmc: re-implementing tmc_read_prepare/unprepare() functions To: Mathieu Poirier References: <1460483692-25061-1-git-send-email-mathieu.poirier@linaro.org> <1460483692-25061-4-git-send-email-mathieu.poirier@linaro.org> <570FCF45.8010809@arm.com> Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" From: Suzuki K Poulose Message-ID: <571127BD.5030107@arm.com> Date: Fri, 15 Apr 2016 18:41:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/16 16:40, Mathieu Poirier wrote: > On 14 April 2016 at 11:11, Suzuki K Poulose wrote: >> >> Nit. If you move the TMC_CONFIG_TYPE_ETB here, you could fall through from >> TYPE_ETF: i.e, > > Yes, that's what the end result look like [1]. I will refactor to > make the transition cleaner. > > [1]. https://git.linaro.org/kernel/coresight.git/blob/refs/heads/next:/drivers/hwtracing/coresight/coresight-tmc.c#l76 Ok, no need to refactor here then. >> >> Reviewed-by: Suzuki K Poulose Cheers Suzuki