From: Neil Armstrong <narmstrong@baylibre.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
tglx@linutronix.de, Russell King <rmk+kernel@arm.linux.org.uk>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 1/2] clocksource: sp804: Add support for OX810SE 24bit timer width
Date: Sat, 16 Apr 2016 21:07:56 +0200 [thread overview]
Message-ID: <57128D8C.4000801@baylibre.com> (raw)
In-Reply-To: <CANLsYkyKkFZOnzQBMHUZ=_y-EfcheAfPTdUZYpPWf_EPREeO0A@mail.gmail.com>
On 04/01/2016 05:33 PM, Mathieu Poirier wrote:
> On 1 April 2016 at 08:22, Neil Armstrong <narmstrong@baylibre.com> wrote:
Hi Matthieu,
Thanks for the review.
>> + /* OX810SE Uses a special 24bit width */
>> + if (of_device_is_compatible(np, "oxsemi,ox810se-rps-timer"))
>> + width = 24;
>
> Wouldn't it be better to add a new optional property for this? If the
> property is not specified then we default to a width of 32. Otherwise
> the new width is configured. That way we don't have to add a new
> compatible string every time (however often) a special width is
> encountered.
As explained by Rob Herring, this HW is compatible with SP804 but is /not/ an IP from ARM
and has been customized to support 24bit.
Having a DT property for this width is not wanted actually since it makes no sense for the
original SP804 IP, so it should be handled per vendor.
>
> Otherwise I think the code facelift looks good,
> Mathieu
Is there any other blocking points ?
The point to have a change on sp804 is to economize a new very similar driver for oxnas.
Neil
next prev parent reply other threads:[~2016-04-16 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 14:22 [PATCH 0/2] clocksource: sp804: Add OX810SE 24bit mode Support Neil Armstrong
2016-04-01 14:22 ` [PATCH 1/2] clocksource: sp804: Add support for OX810SE 24bit timer width Neil Armstrong
2016-04-01 15:33 ` Mathieu Poirier
2016-04-16 19:07 ` Neil Armstrong [this message]
2016-04-22 7:46 ` Daniel Lezcano
2016-04-22 7:53 ` Thomas Gleixner
2016-04-25 14:48 ` Neil Armstrong
2016-04-26 16:30 ` Daniel Lezcano
2016-05-11 7:31 ` Neil Armstrong
2016-04-01 14:22 ` [PATCH 2/2] dt-bindings: timer: sp804: add new compatible for OX810SE SoC Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57128D8C.4000801@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).