From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751872AbcDRFmS (ORCPT ); Mon, 18 Apr 2016 01:42:18 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:58125 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbcDRFmQ (ORCPT ); Mon, 18 Apr 2016 01:42:16 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f79c86d0000012ad-59-571473b42846 Content-transfer-encoding: 8BIT Message-id: <571473B4.6010406@samsung.com> Date: Mon, 18 Apr 2016 14:42:12 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Sebastian Reichel Cc: dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RESEND PATCH 1/3] power: charger-manager: Replace deprecatd API of extcon References: <1460681016-2770-1-git-send-email-cw00.choi@samsung.com> <1460681016-2770-2-git-send-email-cw00.choi@samsung.com> <20160415141318.GA24087@earth> In-reply-to: <20160415141318.GA24087@earth> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsWyRsSkWHdrsUi4weTLTBaTnrxntph/5Byr xcSVk5ktLu+aw2bxufcIo8Xp3SUObB47Z91l99i8Qstj06pONo/Pm+QCWKK4bFJSczLLUov0 7RK4Mp483M5c0CNVce/CVtYGxh8iXYycHBICJhIz/s9lhLDFJC7cW88GYgsJrGCU2NapClOz bMp+Roj4LEaJa1/BbF4BQYkfk++xdDFycDALyEscuZQNEmYWUJeYNG8RcxcjF1D5A0aJmx/b mCHqtSR2fGhlArFZBFQlevcfYAWx2YDi+1/cYAOZIyoQIdF9ohIkLCKgJvH+0lMWkDnMAs2M ElvWzGMHSQgLREqcWNQMtWABo8TDi5tZQBKcAtoS6xsvs4IkJASOsUt0/vkAtU1A4tvkQ2CX SgjISmw6wAzxmKTEwRU3WCYwis1C8s8shH9mIflnASPzKkbR1ILkguKk9CJjveLE3OLSvHS9 5PzcTYzA2Dr971n/Dsa7B6wPMQpwMCrx8EYwiIQLsSaWFVfmHmI0BTpiIrOUaHI+MILzSuIN jc2MLExNTI2NzC3NlMR5F0r9DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAmB//xnx9yCGm a2+uCiydnTLl+QI3eVYfftOnz6auqujb8KSQy4c3xnf5FEEnO6vaT2mlq1Z/Fnm5sr2z5Szr s5y333Z4bdfUPaTb+mavlGJptmTW/bCpDDeZC5fHTdmk6LDohOudSz4HTp00cLav/ceksmJ+ 2BdJnYdbX5deM52kOnVTLLtyrRJLcUaioRZzUXEiAPDCmT+oAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVy+t9jQd0txSLhBnsuWFlMevKe2WL+kXOs FhNXTma2uLxrDpvF594jjBand5c4sHnsnHWX3WPzCi2PTas62Tw+b5ILYIlqYLTJSE1MSS1S SM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAdqtpFCWmFMKFApILC5W 0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcx48nA7c0GPVMW9C1tZGxh/iHQxcnJICJhILJuy nxHCFpO4cG89G4gtJDCLUeLaV7A4r4CgxI/J91i6GDk4mAXkJY5cygYJMwuoS0yat4i5i5EL qPwBo8TNj23MEPVaEjs+tDKB2CwCqhK9+w+wgthsQPH9L26wgcwRFYiQ6D5RCRIWEVCTeH/p KQvIHGaBZkaJLWvmsYMkhAUiJU4saoZasIBR4uHFzSwgCU4BbYn1jZdZJzACXYlw3yyE+2Yh uW8BI/MqRonUguSC4qT0XMO81HK94sTc4tK8dL3k/NxNjOAIfia1g/HgLvdDjAIcjEo8vBEM IuFCrIllxZW5hxglOJiVRHhf5gOFeFMSK6tSi/Lji0pzUosPMZoCPTiRWUo0OR+YXPJK4g2N TcyMLI3MDS2MjM2VxHkf/18XJiSQnliSmp2aWpBaBNPHxMEp1cCYv2Faz0GLr08+d+offzrJ /dh345Dr92V5Pbhlv3tsmXVW5mnJEaGlhqKOHufib7ieObCdrcXJN/3rVE033/0xXSL6l806 1644lLfS6c/qS78Pandl3k83Plkl+njT2ccHT778kHq30Mn+06KqRaZ3qxizWue3z7FfkOfw WLDAQvix4beaIMVMJZbijERDLeai4kQAWnEW3PYCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, On 2016년 04월 15일 23:13, Sebastian Reichel wrote: > Hi, > > On Fri, Apr 15, 2016 at 09:43:34AM +0900, Chanwoo Choi wrote: >> This patch removes the deprecated notifier API of extcon framework and then use >> the new extcon API[2] with the unique id[1] to indicate the each external >> connector. Alter deprecated API as following: >> - extcon_register_interest() -> extcon_register_notifier() >> - extcon_unregister_interest() -> extcon_unregister_notifier() >> >> And, extcon alters the name of USB charger connector in patch[3] as following: >> - EXTCON_CHG_USB_SDP /* Standard Downstream Port */ >> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ >> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ >> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */ >> >> So, the name of external charger connector are changed as following: >> - "USB" -> "SDP" >> - "TA" -> "DCP" >> >> [1] Commit 2a9de9c0f08d61 >> - ("extcon: Use the unique id for external connector instead of string) >> [2] Commit 046050f6e623e4 >> - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon >> [3] Commit 11eecf910bd81d >> - ("extcon: Modify the id and name of external connector") >> >> Signed-off-by: Chanwoo Choi >> --- >> .../bindings/power_supply/charger-manager.txt | 4 +-- >> drivers/power/charger-manager.c | 31 ++++++++++++++-------- >> include/linux/power/charger-manager.h | 4 +-- >> 3 files changed, 24 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/power_supply/charger-manager.txt b/Documentation/devicetree/bindings/power_supply/charger-manager.txt >> index ec4fe9de3137..73193e380dc2 100644 >> --- a/Documentation/devicetree/bindings/power_supply/charger-manager.txt >> +++ b/Documentation/devicetree/bindings/power_supply/charger-manager.txt >> @@ -65,13 +65,13 @@ Example : >> regulator@0 { >> cm-regulator-name = "chg-reg"; >> cable@0 { >> - cm-cable-name = "USB"; >> + cm-cable-id = 5; /* EXTCON_CHG_USB_SDP */ >> cm-cable-extcon = "extcon-dev.0"; >> cm-cable-min = <475000>; >> cm-cable-max = <500000>; >> }; >> cable@1 { >> - cm-cable-name = "TA"; >> + cm-cable-id = 6; /* EXTCON_CHG_USB_DCP */ >> cm-cable-extcon = "extcon-dev.0"; >> cm-cable-min = <650000>; >> cm-cable-max = <675000>; > > This breaks DT ABI. Looks like charger-manager is not used in > mainline,but I guess ther should be an explicit Acked-By from > a DT binding maintainer. As I mentioned on other mail to Rob, the purpose of this patch removes the deprecated the EXTCON APIs. So, I touched the DT binding. About DT ABI about charger-manager, we should handle it on separate patches. Also I think the defines should be in > some header includable from DTS, so that something like this > can be done: > > cm-cable-id = ; I agree to use some definition for the kind of charger cable. But, Not yet. I'm preparing the EXTCON update to use the definitions on Device Tree file. I'll send some separate patches in the near future. > > Apart from that: > > Acked-By: Sebastian Reichel Thanks for review. Best Regards, Chanwoo Choi