From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbcDRJoH (ORCPT ); Mon, 18 Apr 2016 05:44:07 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:33889 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbcDRJoG (ORCPT ); Mon, 18 Apr 2016 05:44:06 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: broonie@kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: <6f16cc54279384dc482cf15711861a43> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5714AC57.2070901@rock-chips.com> Date: Mon, 18 Apr 2016 17:43:51 +0800 From: Xing Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mark Brown CC: linux-rockchip@lists.infradead.org, heiko@sntech.de, Adam.Thomson@diasemi.com, sugar.zhang@rock-chips.com, jay.xu@rock-chips.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec References: <1460967452-24574-1-git-send-email-zhengxing@rock-chips.com> <1460967452-24574-2-git-send-email-zhengxing@rock-chips.com> <20160418092218.GL3217@sirena.org.uk> In-Reply-To: <20160418092218.GL3217@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 2016年04月18日 17:22, Mark Brown wrote: > On Mon, Apr 18, 2016 at 04:17:30PM +0800, Xing Zheng wrote: >> This patch add a callback when a codec have the jack detect feature. >> +void snd_soc_jack_codec_detect(struct snd_soc_codec *codec, >> + struct snd_soc_jack *jack) >> +{ >> + if (codec&& codec->driver&& codec->driver->detect_jack) >> + codec->driver->detect_jack(codec, jack); >> +} >> +EXPORT_SYMBOL_GPL(snd_soc_jack_codec_detect); > I've no idea what this is supposed to do sorry, you need a much better > changelog and probably also a restructuring of the code. This says it > is adding a callback but it doesn't do that, it adds an export of a > function that calls an operation in a driver with no explanation. Yes, sorry to forgot to add description for this API. The patch_1/3 add an export of a function that calls the _detect_jack_ function when a codec supports jack detection and fill the _detect_jack_ function in the struct snd_soc_codec_driver. I will clean up the commit message. Thanks. -- - Xing Zheng