From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbcDRXbJ (ORCPT ); Mon, 18 Apr 2016 19:31:09 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:54324 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbcDRXbG convert rfc822-to-8bit (ORCPT ); Mon, 18 Apr 2016 19:31:06 -0400 X-AuditID: cbfee691-f795a6d0000012b5-f6-57156e37ddff MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <57156E36.5090800@samsung.com> Date: Tue, 19 Apr 2016 08:31:02 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Rob Herring , Sebastian Reichel Cc: dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RESEND PATCH 1/3] power: charger-manager: Replace deprecatd API of extcon References: <1460681016-2770-1-git-send-email-cw00.choi@samsung.com> <1460681016-2770-2-git-send-email-cw00.choi@samsung.com> <20160415141318.GA24087@earth> <20160418172406.GA27979@rob-hp-laptop> In-reply-to: <20160418172406.GA27979@rob-hp-laptop> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsWyRsSkQNc8TzTcoHMXq8WkJ++ZLeYfOcdq MXHlZGaLy7vmsFl87j3CaPF/zw52i9O7SxzYPXbOusvusXmFlsemVZ1sHp83yQWwRHHZpKTm ZJalFunbJXBl3HyrUPBZsuJpUy9bA2OzaBcjJ4eEgInEq3Wf2SFsMYkL99azdTFycQgJrGCU 6J65lx2m6NqsXawQiVmMEgemnmIBSfAKCEr8mHwPzGYWUJeYNG8RM4QtIrHi+ylGCFtbYtnC 18wQzQ8YJXrW72aGaNaSeHBiNxOIzSKgKvHj70WwBjag+P4XN4DO4OAQFYiQ6D5RCRIWEXCV mLvuOwvIHGaBZkaJLWvmgV0nLBApcWJRM9SC44wSK1oPgl3EKWAssfbuCbB/JATOsUs8WHqN DWKbgMS3yYdYQDZICMhKbDrADPGmpMTBFTdYJjCKz0Ly3Cwkz81C8twsJM8tYGRZxSiaWpBc UJyUXmSqV5yYW1yal66XnJ+7iREYm6f/PZu4g/H+AetDjAIcjEo8vBEMIuFCrIllxZW5hxhN gS6ayCwlmpwPTAB5JfGGxmZGFqYmpsZG5pZmSuK8OtI/g4UE0hNLUrNTUwtSi+KLSnNSiw8x MnFwSjUwmnRe/twVctn65frPfn7HmyKzOe9HPDHkLVNIZ59psoX/t3FuwCvepp3z0k49ck0S 4Nw394pw7pVT4joePbrPc/z+F3pqMcn3nnIrj5i+MjYq7sT14Amn5gmrvFm48aDswwqGSg7H hUZHPyYvEcvfFzj/l/f3WCF9l+OfdkYl+qdNC2SsT72rxFKckWioxVxUnAgAPkm2MMgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsVy+t9jQV3zPNFwg5MiFpOevGe2mH/kHKvF xJWTmS0u75rDZvG59wijxf89O9gtTu8ucWD32DnrLrvH5hVaHptWdbJ5fN4kF8AS1cBok5Ga mJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0X0mhLDGnFCgU kFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMOYceTjQ5aCk5IV0/fPZm5gvCnSxcjJISFg InFt1i5WCFtM4sK99WxdjFwcQgKzGCUOTD3FApLgFRCU+DH5HpDNwcEsIC9x5FI2SJhZQF1i 0rxFzBD1DxgletbvZoao15J4cGI3E4jNIqAq8ePvRUYQmw0ovv/FDTaQOaICERLdJypBwiIC rhJz131nAZnDLNDMKLFlzTx2kISwQKTEiUXNUAuOM0qsaD0IdhCngLHE2rsn2CYwAp2JcN8s hPtmIblvASPzKkaJ1ILkguKk9FzDvNRyveLE3OLSvHS95PzcTYzgWH4mtYPx4C73Q4wCHIxK PLwRDCLhQqyJZcWVuYcYJTiYlUR4pTJFw4V4UxIrq1KL8uOLSnNSiw8xmgI9OJFZSjQ5H5hm 8kriDY1NzIwsjcwNLYyMzZXEeR//XxcmJJCeWJKanZpakFoE08fEwSnVwCg9XWPb3sdFy//K 3Hmoo/Ynp3zr4y3+e/ODsjevUlltMGszX8SzDb+fzzF+0lDYPalP2P5Tn9IavlT5uMxaPtk5 j026J60M/q97MeHHt/ZZUiKvbr/X3hqqFhI9+WzNRwf9C4UPUifuXdRl4ntWV/hBVfYMRhmz a0xiulaV8l/EvTb7SwfLH1NiKc5INNRiLipOBADKGm8r+wIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2016년 04월 19일 02:24, Rob Herring wrote: > On Fri, Apr 15, 2016 at 04:13:18PM +0200, Sebastian Reichel wrote: >> Hi, >> >> On Fri, Apr 15, 2016 at 09:43:34AM +0900, Chanwoo Choi wrote: >>> This patch removes the deprecated notifier API of extcon framework and then use >>> the new extcon API[2] with the unique id[1] to indicate the each external >>> connector. Alter deprecated API as following: >>> - extcon_register_interest() -> extcon_register_notifier() >>> - extcon_unregister_interest() -> extcon_unregister_notifier() >>> >>> And, extcon alters the name of USB charger connector in patch[3] as following: >>> - EXTCON_CHG_USB_SDP /* Standard Downstream Port */ >>> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ >>> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ >>> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */ >>> >>> So, the name of external charger connector are changed as following: >>> - "USB" -> "SDP" >>> - "TA" -> "DCP" >>> >>> [1] Commit 2a9de9c0f08d61 >>> - ("extcon: Use the unique id for external connector instead of string) >>> [2] Commit 046050f6e623e4 >>> - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon >>> [3] Commit 11eecf910bd81d >>> - ("extcon: Modify the id and name of external connector") >>> >>> Signed-off-by: Chanwoo Choi >>> --- >>> .../bindings/power_supply/charger-manager.txt | 4 +-- >>> drivers/power/charger-manager.c | 31 ++++++++++++++-------- >>> include/linux/power/charger-manager.h | 4 +-- >>> 3 files changed, 24 insertions(+), 15 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/power_supply/charger-manager.txt b/Documentation/devicetree/bindings/power_supply/charger-manager.txt >>> index ec4fe9de3137..73193e380dc2 100644 >>> --- a/Documentation/devicetree/bindings/power_supply/charger-manager.txt >>> +++ b/Documentation/devicetree/bindings/power_supply/charger-manager.txt >>> @@ -65,13 +65,13 @@ Example : >>> regulator@0 { >>> cm-regulator-name = "chg-reg"; >>> cable@0 { >>> - cm-cable-name = "USB"; >>> + cm-cable-id = 5; /* EXTCON_CHG_USB_SDP */ >>> cm-cable-extcon = "extcon-dev.0"; >>> cm-cable-min = <475000>; >>> cm-cable-max = <500000>; >>> }; >>> cable@1 { >>> - cm-cable-name = "TA"; >>> + cm-cable-id = 6; /* EXTCON_CHG_USB_DCP */ >>> cm-cable-extcon = "extcon-dev.0"; >>> cm-cable-min = <650000>; >>> cm-cable-max = <675000>; >> >> This breaks DT ABI. Looks like charger-manager is not used in >> mainline, but I guess ther should be an explicit Acked-By from >> a DT binding maintainer. Also I think the defines should be in >> some header includable from DTS, so that something like this >> can be done: > > I already commented that the binding to start with looks like crap > (For starters, "extcon-dev.0" is a Linux device name?) and this does not > appear to be an improvement. I already replied for your comment on other mail[1]. [1] https://lkml.org/lkml/2016/3/31/199 This patch never update the charger-manager. Just remove the deprecated EXTCON API to prevent build error. Thanks, Chanwoo Choi