From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752506AbcDSHJS (ORCPT ); Tue, 19 Apr 2016 03:09:18 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:18316 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbcDSHJR (ORCPT ); Tue, 19 Apr 2016 03:09:17 -0400 X-AuditID: cbfec7f5-f792a6d000001302-45-5715d999b106 Message-id: <5715D998.7030402@samsung.com> Date: Tue, 19 Apr 2016 09:09:12 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Boris Brezillon Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, ezequiel@vanguardiasur.com.ar, pavel@ucw.cz Subject: Re: [PATCH] leds: ledtrig-ide-disk: Move ide_blink_delay to ledtrig_ide_activity() References: <1460990446-24700-1-git-send-email-j.anaszewski@samsung.com> <20160418165715.4668ffa0@bbrezillon> In-reply-to: <20160418165715.4668ffa0@bbrezillon> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsVy+t/xy7ozb4qGG7y9KG9x4MVCFouNLz6z WFzeNYfNYuubdYwWd08dZbPYvespqwObx5NNFxk99sz/weqxYvV3do+uI9fZPD5vkgtgjeKy SUnNySxLLdK3S+DKuDTvCUvBA7aKWy2nWRsYL7F2MXJySAiYSMy6v4QFwhaTuHBvPRuILSSw lFFi/y7hLkYuIPsZo8TJCRuZQRK8AloS1xf8BGtgEVCVWPdhDZjNJmAo8fPFayYQW1QgQuLP 6X2sEPWCEj8m3wOrERGwkOh4eBRsAbNAncSeXe/BbGGBWIn/t58wQizOl9j+bxVYnBNoZsOM 2awQ9dYSKydtY4Sw5SU2r3nLPIFRYBaSFbOQlM1CUraAkXkVo2hqaXJBcVJ6rpFecWJucWle ul5yfu4mRkhof93BuPSY1SFGAQ5GJR7eFUWi4UKsiWXFlbmHGCU4mJVEeE2vAoV4UxIrq1KL 8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgmy8TBKdXAuK61VjNlqt1/ls5tRs5P 11mKS1n0bFMXs5vHe8A9rUJWdJqVQLiPU+xTtTdrAyXPmczbtLpIe/fc7KR14XNTmaKYLtoY c/oGBRo8/G1e1LOAZ/FUFpVPzeXlpokOYsKT691dz1QJPVhk2BO3YufPGEeNgKu93mIXl2fp JOeXBUaH7X/6XV+JpTgj0VCLuag4EQAVD99haQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, Thanks for the review, patch applied. Best regards, Jacek Anaszewski On 04/18/2016 04:57 PM, Boris Brezillon wrote: > On Mon, 18 Apr 2016 16:40:46 +0200 > Jacek Anaszewski wrote: > >> Parameters delay_on and delay_off of led_trigger_blink_oneshot() >> are pointers, to enable blink interval adjustment by LED class drivers >> of the controllers that implement hardware blinking. >> >> Move ide_blink_delay variable to ledtrig_ide_activity() in order to >> prevent the situation when adjustment committed by one LED class >> driver influences blink interval of the software fallback blink feature, >> that is applied to the drivers that don't implement blink_set op. >> >> Signed-off-by: Jacek Anaszewski > > Reviewed-by: Boris Brezillon