From: Mason <slash.tmp@free.fr>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Sebastian Frias <sf84@laposte.net>,
Mans Rullgard <mans@mansr.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test
Date: Tue, 19 Apr 2016 14:15:15 +0200 [thread overview]
Message-ID: <57162153.4070707@free.fr> (raw)
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Commit 0881841f7e78 changed "if (ret != 0)" to "if (!ret)"
Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init")
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
drivers/clocksource/tango_xtal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clocksource/tango_xtal.c b/drivers/clocksource/tango_xtal.c
index 2bcecafdeaea..0464c52e61f1 100644
--- a/drivers/clocksource/tango_xtal.c
+++ b/drivers/clocksource/tango_xtal.c
@@ -22,7 +22,7 @@ static u64 notrace read_sched_clock(void)
static void __init tango_clocksource_init(struct device_node *np)
{
struct clk *clk;
- int xtal_freq, ret;
+ int xtal_freq, err;
xtal_in_cnt = of_iomap(np, 0);
if (xtal_in_cnt == NULL) {
@@ -40,9 +40,9 @@ static void __init tango_clocksource_init(struct device_node *np)
delay_timer.freq = xtal_freq;
delay_timer.read_current_timer = read_xtal_counter;
- ret = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350,
+ err = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350,
32, clocksource_mmio_readl_up);
- if (!ret) {
+ if (err) {
pr_err("%s: registration failed\n", np->full_name);
return;
}
--
2.8.1
next reply other threads:[~2016-04-19 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 12:15 Mason [this message]
2016-04-19 13:13 ` [PATCH] clocksource/drivers/tango-xtal: Fix incorrect test Daniel Lezcano
2016-04-19 14:05 ` Mason
2016-04-19 14:59 ` Daniel Lezcano
2016-04-19 17:21 ` Mason
2016-04-19 17:31 ` Daniel Lezcano
2016-04-19 18:22 ` Mason
2016-04-20 4:55 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57162153.4070707@free.fr \
--to=slash.tmp@free.fr \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=sf84@laposte.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox