From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753992AbcDSMU4 (ORCPT ); Tue, 19 Apr 2016 08:20:56 -0400 Received: from foss.arm.com ([217.140.101.70]:39365 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753965AbcDSMUy (ORCPT ); Tue, 19 Apr 2016 08:20:54 -0400 Subject: Re: [PATCH V2 05/15] coresight: tmc: splitting driver in ETB/ETF and ETR components To: Mathieu Poirier , linux-arm-kernel@lists.infradead.org References: <1460483692-25061-1-git-send-email-mathieu.poirier@linaro.org> <1460483692-25061-6-git-send-email-mathieu.poirier@linaro.org> Cc: linux-kernel@vger.kernel.org From: Suzuki K Poulose Message-ID: <571622A3.4020103@arm.com> Date: Tue, 19 Apr 2016 13:20:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460483692-25061-6-git-send-email-mathieu.poirier@linaro.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/16 18:54, Mathieu Poirier wrote: > The TMC block can operate in 3 modes (ETB, ETF and ETR) and accessed > via two interfaces (sysFS and Perf). That makes 6 mode to cover, which > is way too much coupling for a single file. > > This patch splits the original TMC driver in 2 halves, one for ETB/ETF > and another one for ETR mode. A common core is kept for functionality > common to all 3 modes. > > Signed-off-by: Mathieu Poirier > diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h > index 2d7d52747b4e..b99d4dfc1d0b 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc.h > +++ b/drivers/hwtracing/coresight/coresight-tmc.h > @@ -18,6 +18,8 @@ > #ifndef _CORESIGHT_TMC_H > #define _CORESIGHT_TMC_H > > +#include > + What was this for ? Irrespective of that, Reviewed-by: Suzuki K Poulose