From: Adrian Hunter <adrian.hunter@intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small
Date: Tue, 19 Apr 2016 16:28:11 +0300 [thread overview]
Message-ID: <5716326B.2040403@intel.com> (raw)
In-Reply-To: <CAK7LNAScX-JP13w4zZ3Fb=9HQQeqtzN0iyxocGBkLbeZyHxcPw@mail.gmail.com>
On 19/04/16 14:46, Masahiro Yamada wrote:
> Hi Adrian,
>
>
> 2016-04-19 20:32 GMT+09:00 Adrian Hunter <adrian.hunter@intel.com>:
>> On 14/04/16 05:29, Masahiro Yamada wrote:
>>> This code checks the resource size and displays an error message if
>>> it is too small, but still moves forward. Let is fail in that case.
>>
>> is -> it
>>
>> How do you know there aren't drivers that actually have a smaller size?
>
> No, I do not know.
>
> This is an error message, so I think it should fail in that case.
>
>
> Maybe, can we drop this check completely?
Yes, I think so.
next prev parent reply other threads:[~2016-04-19 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 2:29 [PATCH 0/7] mmc: sdhci-pltfm: fix and tidy up sdhci_pltfm_init() Masahiro Yamada
2016-04-14 2:29 ` [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small Masahiro Yamada
2016-04-19 11:32 ` Adrian Hunter
2016-04-19 11:46 ` Masahiro Yamada
2016-04-19 13:28 ` Adrian Hunter [this message]
2016-04-14 2:29 ` [PATCH 2/7] mmc: sdhci-pltfm: check return value of platform_get_irq() Masahiro Yamada
2016-04-14 2:29 ` [PATCH 3/7] mmc: sdhci-pltfm: use devm_request_mem_region() Masahiro Yamada
2016-04-14 2:29 ` [PATCH 4/7] mmc: sdhci-pltfm: use devm_ioremap() Masahiro Yamada
2016-04-14 2:29 ` [PATCH 5/7] mmc: sdhci-pltfm: use devm_ioremap_resource() Masahiro Yamada
2016-04-14 2:29 ` [PATCH 6/7] mmc: sdhci-pltfm: move devm_ioremap_resource() up Masahiro Yamada
2016-04-14 2:29 ` [PATCH 7/7] mmc: sdhci-pltfm: call platform_get_irq() before sdhci_alloc_host() Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5716326B.2040403@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox