From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754607AbcDSNcA (ORCPT ); Tue, 19 Apr 2016 09:32:00 -0400 Received: from mga02.intel.com ([134.134.136.20]:59725 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865AbcDSNb7 (ORCPT ); Tue, 19 Apr 2016 09:31:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,506,1455004800"; d="scan'208";a="948377419" Subject: Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small To: Masahiro Yamada References: <1460600990-10993-1-git-send-email-yamada.masahiro@socionext.com> <1460600990-10993-2-git-send-email-yamada.masahiro@socionext.com> <57161754.5050303@intel.com> Cc: linux-mmc , Linux Kernel Mailing List , Ulf Hansson From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <5716326B.2040403@intel.com> Date: Tue, 19 Apr 2016 16:28:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/16 14:46, Masahiro Yamada wrote: > Hi Adrian, > > > 2016-04-19 20:32 GMT+09:00 Adrian Hunter : >> On 14/04/16 05:29, Masahiro Yamada wrote: >>> This code checks the resource size and displays an error message if >>> it is too small, but still moves forward. Let is fail in that case. >> >> is -> it >> >> How do you know there aren't drivers that actually have a smaller size? > > No, I do not know. > > This is an error message, so I think it should fail in that case. > > > Maybe, can we drop this check completely? Yes, I think so.