From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754599AbcDSOWf (ORCPT ); Tue, 19 Apr 2016 10:22:35 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:55792 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753194AbcDSOWd (ORCPT ); Tue, 19 Apr 2016 10:22:33 -0400 Subject: Re: Runtime warning due to commit 'ARM: OMAP: Catch callers of revision information prior to it being populated' in -next To: Tony Lindgren References: <5715B5EC.2040000@roeck-us.net> <57162261.4070409@ti.com> <20160419141320.GB5995@atomide.com> CC: Guenter Roeck , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-omap , "linux-arm-kernel@lists.infradead.org" From: Nishanth Menon Message-ID: <57163EE5.9090405@ti.com> Date: Tue, 19 Apr 2016 09:21:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160419141320.GB5995@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/19/2016 09:13 AM, Tony Lindgren wrote: > * Nishanth Menon [160419 05:21]: >> On 04/18/2016 11:37 PM, Guenter Roeck wrote: >> >> + linux-omap, linux-arm >> >>> commit 'ARM: OMAP: Catch callers of revision information prior to it >>> being populated' results in a runtime warning on various non-OMAP >>> architectures. I have seen it with the following qemu tests. >>> >>> arm:vexpress-a9:multi_v7_defconfig:vexpress-v2p-ca9 >>> arm:vexpress-a15:multi_v7_defconfig:vexpress-v2p-ca15-tc1 >>> arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zc702 >>> arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zc706 >>> arm:xilinx-zynq-a9:multi_v7_defconfig:zynq-zed >>> arm:midway:multi_v7_defconfig:ecx-2000 >>> arm:smdkc210:multi_v7_defconfig:exynos4210-smdkv310 >>> >>> It is also reported by kernelci.org in at least one boot test for imx6q-cm-fx6. >> >> Thanks for the report... :( > > Oh crap, sorry about that. I'll revert that commit immediately. > Thanks. Sorry about the same as well.. >>> The warning is as follows. >>> >>> ------------[ cut here ]------------ >>> WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/id.c:49 omap_rev+0x3c/0x50 >>> Modules linked in: >>> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.6.0-rc2-next-20160411 #1 >>> Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) >>> [] (unwind_backtrace) from [] (show_stack+0x10/0x14) >>> [] (show_stack) from [] (dump_stack+0x84/0xa4) >>> [] (dump_stack) from [] (__warn+0xd4/0x100) >>> [] (__warn) from [] (warn_slowpath_null+0x20/0x28) >>> [] (warn_slowpath_null) from [] (omap_rev+0x3c/0x50) >>> [] (omap_rev) from [] (__omap4_sar_ram_init+0x8/0x88) >>> [] (__omap4_sar_ram_init) from [] (do_one_initcall+0x3c/0x16c) >>> [] (do_one_initcall) from [] (kernel_init_freeable+0x70/0x1ec) >>> [] (kernel_init_freeable) from [] (kernel_init+0x8/0x110) >>> [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) >>> ---[ end trace cb88537fdc8fa200 ]--- >>> >>> Please have a look. >> >> Tony, >> Should we get rid of omap_initcall callers(move them into >> board-generic call path or lower the check not to include default of 0? > > Most of those will disappear when we drop the legacy booting support > for omap3. I would not touch those before then to avoid churn with > the legacy code. Sounds good to me. -- Regards, Nishanth Menon