From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754442AbcDTG4d (ORCPT ); Wed, 20 Apr 2016 02:56:33 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:42892 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753368AbcDTG4a (ORCPT ); Wed, 20 Apr 2016 02:56:30 -0400 X-AuditID: cbfec7f5-f792a6d000001302-2d-5717281b8131 Subject: Re: [PATCH v2] pinctrl-exynos5440: Use off-stack memory for pinctrl_gpio_range To: Andrew Jeffery , Tomasz Figa References: <1461117257-27048-1-git-send-email-andrew@aj.id.au> Cc: Sylwester Nawrocki , Linus Walleij , Kukjin Kim , Thomas P Abraham , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5717281A.70906@samsung.com> Date: Wed, 20 Apr 2016 08:56:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1461117257-27048-1-git-send-email-andrew@aj.id.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRmVeSWpSXmKPExsVy+t/xy7rSGuLhBudv6Frsusxh8fqFoUX/ 49fMFlP+LGey2PT4GqvF5vl/GC0u75rDZjHj/D4mi8Nv2lktFmx8xGjRsYzRYtWuP4wOPB5X 23exe+ycdZfdY9OqTjaPO9f2sHlsXlLv0bdlFaPH501yAexRXDYpqTmZZalF+nYJXBkLp19k LbjGX/FgxXmWBsa3PF2MnBwSAiYSp+ddZYKwxSQu3FvP1sXIxSEksJRRYs2GLjaQhJDAM0aJ f5+Suhg5OIQFIiWmrGEFCYsIeErsWnsLqsRe4vH7h0wgvcwCR5kkpl26BFbEJmAssXn5ErAi XgENiTc/WsCWsQioSlxa1c0MYosKREg8mXuSEaJGUOLH5HssIDangIPEtPkz2ED2MgvoSdy/ qAUSZhaQl9i85i3zBEaBWUg6ZiFUzUJStYCReRWjaGppckFxUnqukV5xYm5xaV66XnJ+7iZG SHx83cG49JjVIUYBDkYlHt4VRaLhQqyJZcWVuYcYJTiYlUR4PyiIhwvxpiRWVqUW5ccXleak Fh9ilOZgURLnnbnrfYiQQHpiSWp2ampBahFMlomDU6qBMZflgMLV9k/n+5dN0vS4f+ObR/7h i1e6vK2UE57M/73ol+5LGdMPm0s42I187OKTH5W3OMwpXpaesF8tsq4g+K5WRdUKTfHpa+Qe Mad9mtY8Z5LPstnFwtPjL0QmH+EKL/c8G2wSaxD5R9em9+nEogNMWoymdiZLpFnNp/suvR3l /aynOadGiaU4I9FQi7moOBEAUaO/aosCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/20/2016 03:54 AM, Andrew Jeffery wrote: > The range is registered into a linked list which can be referenced > throughout the lifetime of the driver. Ensure the range's memory is useful > for the same lifetime by adding it to the driver's private data structure. > > The bug was introduced in the driver's initial commit, which was present in > v3.10. > > Signed-off-by: Andrew Jeffery > Fixes: f0b9a7e521fa ("pinctrl: exynos5440: add pinctrl driver for Samsung EXYNOS5440 SoC") > Cc: stable@vger.kernel.org > --- > Since v1: > > * Add range member kerneldoc addressing Tomasz Figa's comment > > This is my first contribution to the kernel, so hopefully I've followed all the > relevant documentation. If not, please let me know and point me in the right > direction! > > I don't have the means to test the patch, but it compiles. Someone with > appropriate hardware should probably give it a spin. From the responses it > seems that few might have access, and given the nature of the bug it might be > the case that no-one has complained because no-one is affected - is it worth > maintaining going forward? > > drivers/pinctrl/samsung/pinctrl-exynos5440.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) Thank you for your contribution. You already received positive feedback on v1 of this patch: Tomasz acked it ("acked-by") and I reviewed it ("reviewed-by"). These are called "tags". When you resubmit patches (unless there is a significant change in the patch) please always put accumulated tags after existing tags. Usually after signed-off-by, in this case after Cc-stable, so this would look like: Signed-off-by: Andrew Jeffery Fixes: f0b9a7e521fa ("pinctrl: exynos5440: add pinctrl driver for Samsung EXYNOS5440 SoC") Cc: stable@vger.kernel.org Acked-by: Tomasz Figa Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof