* [PATCH] Coccinelle: setup_timer: Add space in front of parentheses
@ 2016-03-20 5:27 Vaishali Thakkar
2016-03-20 12:25 ` Julia Lawall
2016-04-12 21:25 ` [Cocci] " Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Vaishali Thakkar @ 2016-03-20 5:27 UTC (permalink / raw)
To: mmarek
Cc: Gilles.Muller, nicolas.palix, linux-kernel, cocci, nm,
julia.lawall, Vaishali Thakkar
Add space in front of the offending parentheses to silent the
parse error for older Coccinelle versions. This makes the rule
usable with all Coccinelle versions.
Reported-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
---
scripts/coccinelle/api/setup_timer.cocci | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/coccinelle/api/setup_timer.cocci b/scripts/coccinelle/api/setup_timer.cocci
index 8ee0ac3..eb6bd9e 100644
--- a/scripts/coccinelle/api/setup_timer.cocci
+++ b/scripts/coccinelle/api/setup_timer.cocci
@@ -106,7 +106,7 @@ position j0, j1, j2;
@match_function_and_data_after_init_timer_context
depends on !patch &&
!match_immediate_function_data_after_init_timer_context &&
-(context || org || report)@
+ (context || org || report)@
expression a, b, e1, e2, e3, e4, e5;
position j0, j1, j2;
@@
@@ -127,7 +127,7 @@ position j0, j1, j2;
@r3_context depends on !patch &&
!match_immediate_function_data_after_init_timer_context &&
!match_function_and_data_after_init_timer_context &&
-(context || org || report)@
+ (context || org || report)@
expression c, e6, e7;
position r1.p;
position j0, j1;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Coccinelle: setup_timer: Add space in front of parentheses
2016-03-20 5:27 [PATCH] Coccinelle: setup_timer: Add space in front of parentheses Vaishali Thakkar
@ 2016-03-20 12:25 ` Julia Lawall
2016-04-20 7:51 ` Michal Marek
2016-04-12 21:25 ` [Cocci] " Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2016-03-20 12:25 UTC (permalink / raw)
To: Vaishali Thakkar
Cc: mmarek, Gilles.Muller, nicolas.palix, linux-kernel, cocci, nm,
julia.lawall
On Sun, 20 Mar 2016, Vaishali Thakkar wrote:
> Add space in front of the offending parentheses to silent the
> parse error for older Coccinelle versions. This makes the rule
> usable with all Coccinelle versions.
>
> Reported-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> scripts/coccinelle/api/setup_timer.cocci | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/api/setup_timer.cocci b/scripts/coccinelle/api/setup_timer.cocci
> index 8ee0ac3..eb6bd9e 100644
> --- a/scripts/coccinelle/api/setup_timer.cocci
> +++ b/scripts/coccinelle/api/setup_timer.cocci
> @@ -106,7 +106,7 @@ position j0, j1, j2;
> @match_function_and_data_after_init_timer_context
> depends on !patch &&
> !match_immediate_function_data_after_init_timer_context &&
> -(context || org || report)@
> + (context || org || report)@
> expression a, b, e1, e2, e3, e4, e5;
> position j0, j1, j2;
> @@
> @@ -127,7 +127,7 @@ position j0, j1, j2;
> @r3_context depends on !patch &&
> !match_immediate_function_data_after_init_timer_context &&
> !match_function_and_data_after_init_timer_context &&
> -(context || org || report)@
> + (context || org || report)@
> expression c, e6, e7;
> position r1.p;
> position j0, j1;
> --
> 2.1.4
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Coccinelle: setup_timer: Add space in front of parentheses
2016-03-20 12:25 ` Julia Lawall
@ 2016-04-20 7:51 ` Michal Marek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Marek @ 2016-04-20 7:51 UTC (permalink / raw)
To: Julia Lawall, Vaishali Thakkar
Cc: Gilles.Muller, nicolas.palix, linux-kernel, cocci, nm
Dne 20.3.2016 v 13:25 Julia Lawall napsal(a):
>
>
> On Sun, 20 Mar 2016, Vaishali Thakkar wrote:
>
>> Add space in front of the offending parentheses to silent the
>> parse error for older Coccinelle versions. This makes the rule
>> usable with all Coccinelle versions.
>>
>> Reported-by: Nishanth Menon <nm@ti.com>
>> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Applied to kbuild.git#misc.
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Cocci] [PATCH] Coccinelle: setup_timer: Add space in front of parentheses
2016-03-20 5:27 [PATCH] Coccinelle: setup_timer: Add space in front of parentheses Vaishali Thakkar
2016-03-20 12:25 ` Julia Lawall
@ 2016-04-12 21:25 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2016-04-12 21:25 UTC (permalink / raw)
To: Vaishali Thakkar; +Cc: mmarek, nm, linux-kernel, cocci
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
On Sun, Mar 20, 2016 at 10:57:32AM +0530, Vaishali Thakkar wrote:
> Add space in front of the offending parentheses to silent the
> parse error for older Coccinelle versions. This makes the rule
> usable with all Coccinelle versions.
>
> Reported-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Tested-by: Wolfram Sang <wsa@the-dreams.de>
Can we have this in 4.6 as a bugfix? The script is totally broken this
way.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-20 7:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-20 5:27 [PATCH] Coccinelle: setup_timer: Add space in front of parentheses Vaishali Thakkar
2016-03-20 12:25 ` Julia Lawall
2016-04-20 7:51 ` Michal Marek
2016-04-12 21:25 ` [Cocci] " Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox