From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754949AbcGFNsO (ORCPT ); Wed, 6 Jul 2016 09:48:14 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:64762 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754246AbcGFNsK (ORCPT ); Wed, 6 Jul 2016 09:48:10 -0400 From: Arnd Bergmann To: Masahiro Yamada Cc: Michal Marek , "Yann E. MORIN" , Josh Triplett , Darren Hart , Linux Kbuild mailing list , kernel-build-reports@lists.linaro.org, Michal Marek , Thiago Macieira , Linux Kernel Mailing List Subject: Re: [PATCH] [RFC] Kbuild: avoid "make tinyconfig" warnings Date: Wed, 06 Jul 2016 15:49:18 +0200 Message-ID: <5717639.GLOFncF6tL@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20160704142608.2069991-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:v4XAl+/hN0tr6B4x/yA6uJ6yVUdqKnemvhMNf++yABCqaK27yU/ MsPaNv7CSaaeWTenv/KHfSiKCCeZlMxkP+tIEwOImIL8Yn+deCgIXMuk4m4QU3zbsZnu+Px eRJ9ze3wIQvWTxpkTSN9rjjDGSr4zFdqBgth2AqciohH7HziqIa+Fyxoz8skwpeAVJrO2Jr O2lc3Vt7shHQLXXe48eKQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:NCsUBu3HYdw=:fJffgUqSVrR4favWCwKSBF Tb1Mh9h/bFVHAm0S5fVU7pO835EOJjuJkEROO5XF/zlWE9VcuVToMmwkddHMZfwiBlsg9Roon 7b4vnXx0BAn8wxLm2GEwNL558CZJgTwtW770ighDO3B0l0Mm0/SQ97sY3wMRTSNV5gW/1sVoN A2SuXcAUSqYaserw+zPN2iJuZ/QFP+Kf3feHFIX49eI8ytR5scKfVMmWS7700zTt3fWMA4bF2 xKmkqPn+Xpo8slSln2TaIDOqe09VgrQNW+HZHKwn/x68lC2xAzQHymiO/0gPmcRZFj3wmYNz3 GS0ajvkih7hUQfshc9yawTskGfArjCF6ufg1rT4PMZujJYCMJUgSCZDXDi7Nn4fhP7RMgYySC 4aZQUCumjZackz8A18ttnAgyzkjcMZGFncw5aqzXYwZlHwNHYE0A5RsALSJogIUZkQ09AYENc Duem3w25PVNumftNM7JL+5HfMLupc/TRbD3Q+ZbvIzNNlHRQm5NL9+eQitSqtS6fqX9uoRW5J PgcSpPS/VZNpb3776JZwBvW2v/6PSCq0cu6LdAKhB51rE8q6ISkloSu6JpXElzHdx7KYc82ZU xWzPDT/YIijLZCcWM/eMeLCwOCNiQfhgCyIesJigoTNHTBZ18v/SLloVLe4DibnGXetsu3ogH c5mv5zMFtggiwC7CnHiXupUpvxd3htiNnSZhge9oaIOytua/VoRWVwvmGVqxiLdHFMLEcU52k bAL4/oxmH2nYMel2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 6, 2016 11:00:01 AM CEST Masahiro Yamada wrote: > Hi Arnd, > > > 2016-07-04 23:25 GMT+09:00 Arnd Bergmann : > > The introduction of "make *.config" as a shorthand for merging configuration > > files unfortunately introduced some build warnings that we see in every > > single run of the various build bots testing tinyconfig: > > I am not convinced with this statement. > > Why do you think 63a91033d52e is a bad commit? > > > With/without 63a91033d52e, I see the same warnings. > > > $ git log --oneline -1 > 63a9103 kbuild: add generic mergeconfig target, %.config > $ make -s mrproper > $ make tinyconfig >/dev/null > .config:871:warning: override: KERNEL_XZ changes choice state > .config:873:warning: override: SLOB changes choice state > .config:874:warning: override: NOHIGHMEM changes choice state > $ git checkout HEAD^ > Previous HEAD position was 63a9103... kbuild: add generic mergeconfig > target, %.config > HEAD is now at bc8f8f5... merge_config.sh: rename MAKE to RUNMAKE > $ git log --oneline -1 > bc8f8f5 merge_config.sh: rename MAKE to RUNMAKE > $ make -s mrproper > $ make tinyconfig >/dev/null > .config:871:warning: override: KERNEL_XZ changes choice state > .config:873:warning: override: SLOB changes choice state > .config:874:warning: override: NOHIGHMEM changes choice state > Sorry about, my mistake. I misread the original Makefile contents. > > PHONY += tinyconfig > > -tinyconfig: > > - $(Q)$(MAKE) -f $(srctree)/Makefile allnoconfig tiny.config > > +tinyconfig: $(obj)/conf > > + $(Q)$(MAKE) -f $(srctree)/Makefile allnoconfig KCONFIG_ALLCONFIG=$(wildcard $(srctree)/kernel/configs/tiny.config $(srctree)/arch/$(SRCARCH)/configs/tiny.config) > > > > # Help text used by make help > > help: > > > The dependency "tinyconfig: $(obj)/conf" is redundant. > > > It is already specified by: > > allnoconfig allyesconfig allmodconfig alldefconfig randconfig: $(obj)/conf > $< --$@ $(Kconfig) I don't see that yet. How does this line provide the dependency? > What is worse, this patch breaks "make tinyconfig" on x86. Right, Josh also pointed this out. So, let's ignore my incorrect patch for the moment. Do you have any other idea for how to avoid the warning? Arnd