From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932446AbcDTOAF (ORCPT ); Wed, 20 Apr 2016 10:00:05 -0400 Received: from lists.s-osg.org ([54.187.51.154]:50719 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932254AbcDTOAB (ORCPT ); Wed, 20 Apr 2016 10:00:01 -0400 Subject: Re: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup To: Krzysztof Kozlowski , Kukjin Kim , Wolfram Sang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <1461144292-22141-1-git-send-email-k.kozlowski@samsung.com> <1461144292-22141-2-git-send-email-k.kozlowski@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <57178B58.7050104@osg.samsung.com> Date: Wed, 20 Apr 2016 09:59:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1461144292-22141-2-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 04/20/2016 05:24 AM, Krzysztof Kozlowski wrote: > Cleanup the weird function-level comments and remove obvious > documentatoin for probe/remove. > s/documentatoin/documentation > Signed-off-by: Krzysztof Kozlowski > --- I wonder if instead we should change to kernel-doc formatted documentation. All the functions are static so kernel-doc is not really required but still Documentation/kernel-doc-nano-HOWTO.txt says that is suggested for source code layout consistency. But I agree that's either kernel-doc format or minimal as your patch does: Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America