From: Al Stone <ahs3@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Geoff Levand <geoff@infradead.org>,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH] char: Drop bogus dependency of DEVPORT on !M68K
Date: Wed, 20 Apr 2016 13:43:10 -0600 [thread overview]
Message-ID: <5717DBCE.2000303@redhat.com> (raw)
In-Reply-To: <1460364055-10174-1-git-send-email-geert@linux-m68k.org>
On 04/11/2016 02:40 AM, Geert Uytterhoeven wrote:
> According to full-history-linux commit d3794f4fa7c3edc3 ("[PATCH] M68k
> update (part 25)"), port operations are allowed on m68k if CONFIG_ISA is
> defined.
>
> However, commit 153dcc54df826d2f ("[PATCH] mem driver: fix conditional
> on isa i/o support") accidentally changed an "||" into an "&&",
> disabling it completely on m68k. This logic was retained when
> introducing the DEVPORT symbol in commit 4f911d64e04a44c4 ("Make
> /dev/port conditional on config symbol").
>
> Drop the bogus dependency on !M68K to fix this.
>
> Fixes: 153dcc54df826d2f ("[PATCH] mem driver: fix conditional on isa i/o support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/char/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index d3b8ddc6241cac2d..fa56bc757fe98fd1 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -585,7 +585,6 @@ config TELCLOCK
>
> config DEVPORT
> bool
> - depends on !M68K
> depends on ISA || PCI
> default y
>
>
This solves the particular problem I was running into on an arm64 AMD Seattle
system. Thanks!
Tested-by: Al Stone <ahs3@redhat.com>
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------
next prev parent reply other threads:[~2016-04-20 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 8:40 [PATCH] char: Drop bogus dependency of DEVPORT on !M68K Geert Uytterhoeven
2016-04-20 19:43 ` Al Stone [this message]
2016-04-21 9:15 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717DBCE.2000303@redhat.com \
--to=ahs3@redhat.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=geoff@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).