From: Clemens Ladisch <clemens@ladisch.de>
To: David Binderman <dcb314@hotmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] linux-4.6-rc4/sound/pci/ens1370.c:1551: possible bad expression ?
Date: Thu, 21 Apr 2016 08:38:48 +0200 [thread overview]
Message-ID: <57187578.2010609@ladisch.de> (raw)
In-Reply-To: <DUB128-W43C83AA6E3851834E8340F9C6B0@phx.gbl>
David Binderman wrote:
> [linux-4.6-rc4/sound/pci/ens1370.c:1551]: (style) Expression '(X & 0xf0000)>= 0x4' is always false.
What tool generated this message?
> Source code is
>
> if ((ensoniq->ctrl & ES_1371_GPIO_OUTM)>= 4)
> val = 1;
This message is wrong; it is certainly possible for this to be true.
However, there is a different bug: 4 must be ES_1371_GPIO_OUT(4).
Regards,
Clemens
prev parent reply other threads:[~2016-04-21 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DUB128-W44E71E14CBE4AC54396DFA9C6B0@phx.gbl>
[not found] ` <DUB128-W43C83AA6E3851834E8340F9C6B0@phx.gbl>
2016-04-19 13:31 ` linux-4.6-rc4/sound/pci/ens1370.c:1551: possible bad expression ? Takashi Iwai
2016-04-21 6:38 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57187578.2010609@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox