From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbcDUHB2 (ORCPT ); Thu, 21 Apr 2016 03:01:28 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:34739 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751722AbcDUHB0 (ORCPT ); Thu, 21 Apr 2016 03:01:26 -0400 X-AuditID: cbfec7f5-f792a6d000001302-31-57187ac16e68 Subject: Re: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup To: Javier Martinez Canillas , Kukjin Kim , Wolfram Sang , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <1461144292-22141-1-git-send-email-k.kozlowski@samsung.com> <1461144292-22141-2-git-send-email-k.kozlowski@samsung.com> <57178B58.7050104@osg.samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <57187AC0.3000503@samsung.com> Date: Thu, 21 Apr 2016 09:01:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <57178B58.7050104@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t/xa7qHqiTCDV5sZLTYOGM9q8Wbt2uY LF6/MLTof/ya2WLT42usFh1/vzBaXN41h81ixvl9TBYrT8xiduD02LSqk81j85J6jy39d9k9 +rasYvQ4eeoJi8fnTXIBbFFcNimpOZllqUX6dglcGRO/bWIreMRe8WLVKtYGxnVsXYycHBIC JhL3H55ihbDFJC7cWw8U5+IQEljKKHF792lGCOcZo8TEHcsYQaqEBbwlrrTNYgVJiAj8Y5S4 d3QLVNUqRolZVx8xg1QxC1hIbN26mh3EZhMwlti8fAnQXA4OXgEtifkNASBhFgFViVmbJ4GV iwpESDyZexJsAa+AoMSPyfdYQMo5BfQl1nRmgJjMAnoS9y9qQQyXl9i85i3zBEaBWUgaZiFU zUJStYCReRWjaGppckFxUnqukV5xYm5xaV66XnJ+7iZGSPB/3cG49JjVIUYBDkYlHt4NMhLh QqyJZcWVuYcYJTiYlUR45xcDhXhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REggPbEkNTs1 tSC1CCbLxMEp1cBYOdNVW0DgZmJe6zNB/bczj7CapR68MGena0uTguqsVRtUN6wQ+3pr7n7V 3S9yr536d25bzmr5E3krQp//j40wqvdnPM40b94pxhY7Nr/9HNYv9WXs9urte+pjGLItXPv6 djnx2ouO1uePG7OEKb76eb6bw37bRr5K7W/3yr85sZy+5bJQJUtaiaU4I9FQi7moOBEABN1w oXoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/20/2016 03:59 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 04/20/2016 05:24 AM, Krzysztof Kozlowski wrote: >> Cleanup the weird function-level comments and remove obvious >> documentatoin for probe/remove. >> > > s/documentatoin/documentation > >> Signed-off-by: Krzysztof Kozlowski >> --- > > I wonder if instead we should change to kernel-doc formatted documentation. > > All the functions are static so kernel-doc is not really required but still > Documentation/kernel-doc-nano-HOWTO.txt says that is suggested for source > code layout consistency. > > But I agree that's either kernel-doc format or minimal as your patch does: > > Reviewed-by: Javier Martinez Canillas Thanks for review. Indeed switching to kernel-doc would be the best... but that would require a little bit more rewritting than now. I just wanted to fix some weird looking comments. Best regards, Krzysztof