From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbcDUHTq (ORCPT ); Thu, 21 Apr 2016 03:19:46 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:35624 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbcDUHTo (ORCPT ); Thu, 21 Apr 2016 03:19:44 -0400 X-AuditID: cbfec7f5-f792a6d000001302-19-57187f0de0bb Subject: Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1461163076-5959-1-git-send-email-javier@osg.samsung.com> <1461163076-5959-2-git-send-email-javier@osg.samsung.com> Cc: linux-samsung-soc@vger.kernel.org, Wolfram Sang , Kukjin Kim , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <57187F0B.3000002@samsung.com> Date: Thu, 21 Apr 2016 09:19:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1461163076-5959-2-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsVy+t/xa7q89RLhBqs/M1m8ebuGyeL1C0OL /sevmS02Pb7GatHx9wujxeVdc9gsZpzfx2Sx8sQsZgcOj02rOtk8Ni+p99jSf5fdo2/LKkaP k6eesHh83iQXwBbFZZOSmpNZllqkb5fAlfHmXzNzwVXWir6JxxkbGM+xdDFyckgImEhMeXqF FcIWk7hwbz1bFyMXh5DAUkaJjn+zmSCcZ4wSBxoOMYNUCQsESxzbuA/MFhEIlfh38TYjRFEj o8S5w6uZQRxmgdWMEh97jrKBVLEJGEtsXr4EzOYV0JKYfmEDO4jNIqAq8aT/EJgtKhAh8WTu SUaIGkGJH5Pvgd3HKeAmse5RF1ANB9BQPYn7F7VAwswC8hKb17xlnsAoMAtJxyyEqllIqhYw Mq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECAn7rzsYlx6zOsQowMGoxMO7QUYiXIg1say4 MvcQowQHs5IIL08tUIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE0hNLUrNTUwtSi2Cy TBycUg2MwraWebNeGhpOezIpT7mqeqFbANPcd58uhz2tMLRQeLbrtkDfqmKu1Ha99WdMBX49 Xv8xe/KFiVXF0w0SzDctm+3itPoKX7PqGbYfW1zy2Xau2ZHrcHf3/KLgSb92bOB2ebpnbUtF qB+HicdNlwdmAVf3nVPlihVNLS6qkGh4ONX5gkqHunWiEktxRqKhFnNRcSIAJKsm8HcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/20/2016 04:37 PM, Javier Martinez Canillas wrote: > The clk_prepare_enable() function can fail so check the return > value and propagate the error in case of a failure. > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v2: > - Don't print the errno code since that's already printed by the > core when probe fails. Suggested by Krzysztof Kozlowski. > > drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Tested on Trats2 (Exynos4412, samsung,s3c2440-i2c) Tested-by: Krzysztof Kozlowski Best regards, Krzysztof