From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751582AbcDUNVq (ORCPT ); Thu, 21 Apr 2016 09:21:46 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60556 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbcDUNVn (ORCPT ); Thu, 21 Apr 2016 09:21:43 -0400 Subject: Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling To: Sylwester Nawrocki References: <1458780100-8865-1-git-send-email-javier@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Mauro Carvalho Chehab , Kyungmin Park , Kukjin Kim , =?UTF-8?Q?Andreas_F=c3=a4rber?= , linux-media@vger.kernel.org From: Javier Martinez Canillas Message-ID: <5718D3DC.20004@osg.samsung.com> Date: Thu, 21 Apr 2016 09:21:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1458780100-8865-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sylwester, On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote: > The same struct device_node * is used for looking up the I2C sensor, OF > graph endpoint and port. So the reference count is incremented but not > decremented for the endpoint and port nodes. > > Fix this by having separate pointers for each node looked up. > > Signed-off-by: Javier Martinez Canillas > Any comments about this patch? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America