From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541AbcDUQKo (ORCPT ); Thu, 21 Apr 2016 12:10:44 -0400 Received: from foss.arm.com ([217.140.101.70]:56272 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbcDUQKn (ORCPT ); Thu, 21 Apr 2016 12:10:43 -0400 Subject: Re: [PATCH V2 14/15] coresight: tmc: implementing TMC-ETR AUX space API To: Mathieu Poirier , linux-arm-kernel@lists.infradead.org References: <1460483692-25061-1-git-send-email-mathieu.poirier@linaro.org> <1460483692-25061-15-git-send-email-mathieu.poirier@linaro.org> Cc: linux-kernel@vger.kernel.org From: Suzuki K Poulose Message-ID: <5718FB80.90205@arm.com> Date: Thu, 21 Apr 2016 17:10:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460483692-25061-15-git-send-email-mathieu.poirier@linaro.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/04/16 18:54, Mathieu Poirier wrote: > This patch implement the AUX area interfaces required to > use the TMC (configured as an ETR) from the Perf sub-system. > > The heuristic is heavily borrowed from the ETB10 and TMC-ETF > implementation. > > Signed-off-by: Mathieu Poirier > +static void tmc_update_etr_buffer(struct coresight_device *csdev, > + struct perf_output_handle *handle, > + void *sink_config) > +{ > + struct cs_etr_buffers *buf = sink_config; > + > + /* > + * An ETR configured to work in contiguous memory mode works the same > + * was as an ETB or ETF. > + */ > + tmc_update_etf_buffer(csdev, handle, &buf->tmc); Really ? I thought the ETR stores the data to the allocated System RAM and can be read directly from the memory than using the RRD ? Suzuki