Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

Laxman Dewangan
2016-04-25T10:05:13Z

On Monday 25 April 2016 03:30 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Fri, Apr 22, 2016 at 03:39:13PM +0530, Laxman Dewangan wrote:
> [...]
>> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> [...]
>> static struct gpio_chip tegra_gpio_chip = {
> This variable is still file-scoped. Why not get rid of it at the same
> time? It's rather pointless to remove all file-scoped variables except a
> single one, because now the driver still isn't properly equipped to deal
> with multiple instances (however theoretical that may be).
>

Yaah, Alex also pointed that to have the instance of gpio_chip in
tegra_gpio_info and then do as
tgi->gc = tegra_gpio_chip.

same for irq_chip also.

I hope this will resolve the concern.