Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

Thierry Reding
2016-04-25T10:01:03Z

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On Fri, Apr 22, 2016 at 03:39:13PM +0530, Laxman Dewangan wrote:
[...]
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
[...]
> static struct gpio_chip tegra_gpio_chip = {

This variable is still file-scoped. Why not get rid of it at the same
time? It's rather pointless to remove all file-scoped variables except a
single one, because now the driver still isn't properly equipped to deal
with multiple instances (however theoretical that may be).

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]