From: Guenter Roeck <linux@roeck-us.net>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted
Date: Sat, 23 Apr 2016 17:09:09 -0700 [thread overview]
Message-ID: <571C0EA5.3090104@roeck-us.net> (raw)
In-Reply-To: <1458559253-422-1-git-send-email-linux@roeck-us.net>
ping ... still not upstream.
On 03/21/2016 04:20 AM, Guenter Roeck wrote:
> unicore32 fails to compile with the following errors.
>
> mm/memory.c: In function ‘__handle_mm_fault’:
> mm/memory.c:3381: error:
> too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘check_vma_flags’:
> mm/gup.c:456: error:
> too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘vma_permits_fault’:
> mm/gup.c:640: error:
> too many arguments to function ‘arch_vma_access_permitted’
>
> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches")
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/unicore32/include/asm/mmu_context.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
> index e35632ef23c7..62dfc644c908 100644
> --- a/arch/unicore32/include/asm/mmu_context.h
> +++ b/arch/unicore32/include/asm/mmu_context.h
> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
> }
>
> static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> - bool write, bool foreign)
> + bool write, bool execute, bool foreign)
> {
> /* by default, allow everything */
> return true;
>
next prev parent reply other threads:[~2016-04-24 0:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 11:20 [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted Guenter Roeck
2016-03-21 11:47 ` Xuetao Guan
2016-03-23 20:25 ` Guenter Roeck
2016-03-24 0:38 ` Xuetao Guan
2016-04-24 0:09 ` Guenter Roeck [this message]
2016-04-24 12:44 ` Xuetao Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571C0EA5.3090104@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dave.hansen@linux.intel.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox