[PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

[PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

[Guenter Roeck]

unicore32 fails to compile with the following errors.

mm/memory.c: In function ‘__handle_mm_fault’:
mm/memory.c:3381: error:
	too many arguments to function ‘arch_vma_access_permitted’
mm/gup.c: In function ‘check_vma_flags’:
mm/gup.c:456: error:
	too many arguments to function ‘arch_vma_access_permitted’
mm/gup.c: In function ‘vma_permits_fault’:
mm/gup.c:640: error:
	too many arguments to function ‘arch_vma_access_permitted’

Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches")
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/unicore32/include/asm/mmu_context.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
index e35632ef23c7..62dfc644c908 100644
--- a/arch/unicore32/include/asm/mmu_context.h
+++ b/arch/unicore32/include/asm/mmu_context.h
@@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
 }
 
 static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
-		bool write, bool foreign)
+		bool write, bool execute, bool foreign)
 {
 	/* by default, allow everything */
 	return true;
-- 
2.5.0

Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

[Xuetao Guan]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain;charset=gb2312, Size: 1507 bytes --]

> unicore32 fails to compile with the following errors.
>
> mm/memory.c: In function ‘__handle_mm_fault�:
> mm/memory.c:3381: error:
> 	too many arguments to function ‘arch_vma_access_permitted�
> mm/gup.c: In function ‘check_vma_flags�:
> mm/gup.c:456: error:
> 	too many arguments to function ‘arch_vma_access_permitted�
> mm/gup.c: In function ‘vma_permits_fault�:
> mm/gup.c:640: error:
> 	too many arguments to function ‘arch_vma_access_permitted�
>
> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction
> fetches")
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Thanks.

Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>

> ---
>  arch/unicore32/include/asm/mmu_context.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/unicore32/include/asm/mmu_context.h
> b/arch/unicore32/include/asm/mmu_context.h
> index e35632ef23c7..62dfc644c908 100644
> --- a/arch/unicore32/include/asm/mmu_context.h
> +++ b/arch/unicore32/include/asm/mmu_context.h
> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct
> *mm,
>  }
>
>  static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> -		bool write, bool foreign)
> +		bool write, bool execute, bool foreign)
>  {
>  	/* by default, allow everything */
>  	return true;
> --
> 2.5.0
>

Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

[Guenter Roeck]

On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
> > unicore32 fails to compile with the following errors.
> >
> > mm/memory.c: In function 鈥榑_handle_mm_fault鈥�:
> > mm/memory.c:3381: error:
> > 	too many arguments to function 鈥榓rch_vma_access_permitted鈥�
> > mm/gup.c: In function 鈥榗heck_vma_flags鈥�:
> > mm/gup.c:456: error:
> > 	too many arguments to function 鈥榓rch_vma_access_permitted鈥�
> > mm/gup.c: In function 鈥榲ma_permits_fault鈥�:
> > mm/gup.c:640: error:
> > 	too many arguments to function 鈥榓rch_vma_access_permitted鈥�
> >
> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction
> > fetches")
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Thanks.
> 
> Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
> 
Who is going to send the patch upstream ?

Guenter

> > ---
> >  arch/unicore32/include/asm/mmu_context.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/unicore32/include/asm/mmu_context.h
> > b/arch/unicore32/include/asm/mmu_context.h
> > index e35632ef23c7..62dfc644c908 100644
> > --- a/arch/unicore32/include/asm/mmu_context.h
> > +++ b/arch/unicore32/include/asm/mmu_context.h
> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct
> > *mm,
> >  }
> >
> >  static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> > -		bool write, bool foreign)
> > +		bool write, bool execute, bool foreign)
> >  {
> >  	/* by default, allow everything */
> >  	return true;
> > --
> > 2.5.0
> >
> 

Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

[Xuetao Guan]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain;charset=gb2312, Size: 1872 bytes --]

> On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
>> > unicore32 fails to compile with the following errors.
>> >
>> > mm/memory.c: In function 鈥榑_handle_mm_fault��:
>> > mm/memory.c:3381: error:
>> > 	too many arguments to function
>> 鈥榓rch_vma_access_permitted��
>> > mm/gup.c: In function 鈥榗heck_vma_flags��:
>> > mm/gup.c:456: error:
>> > 	too many arguments to function
>> 鈥榓rch_vma_access_permitted��
>> > mm/gup.c: In function 鈥榲ma_permits_fault��:
>> > mm/gup.c:640: error:
>> > 	too many arguments to function
>> 鈥榓rch_vma_access_permitted��
>> >
>> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate
>> instruction
>> > fetches")
>> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
>> > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > Cc: Ingo Molnar <mingo@kernel.org>
>> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Thanks.
>>
>> Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
>>
> Who is going to send the patch upstream ?
>
> Guenter

I will do. Thanks.

Xuetao

>
>> > ---
>> >  arch/unicore32/include/asm/mmu_context.h | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/arch/unicore32/include/asm/mmu_context.h
>> > b/arch/unicore32/include/asm/mmu_context.h
>> > index e35632ef23c7..62dfc644c908 100644
>> > --- a/arch/unicore32/include/asm/mmu_context.h
>> > +++ b/arch/unicore32/include/asm/mmu_context.h
>> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct
>> mm_struct
>> > *mm,
>> >  }
>> >
>> >  static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> > -		bool write, bool foreign)
>> > +		bool write, bool execute, bool foreign)
>> >  {
>> >  	/* by default, allow everything */
>> >  	return true;
>> > --
>> > 2.5.0
>> >
>>
>

Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

[Guenter Roeck]

ping ... still not upstream.

On 03/21/2016 04:20 AM, Guenter Roeck wrote:
> unicore32 fails to compile with the following errors.
>
> mm/memory.c: In function ‘__handle_mm_fault’:
> mm/memory.c:3381: error:
> 	too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘check_vma_flags’:
> mm/gup.c:456: error:
> 	too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘vma_permits_fault’:
> mm/gup.c:640: error:
> 	too many arguments to function ‘arch_vma_access_permitted’
>
> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches")
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   arch/unicore32/include/asm/mmu_context.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
> index e35632ef23c7..62dfc644c908 100644
> --- a/arch/unicore32/include/asm/mmu_context.h
> +++ b/arch/unicore32/include/asm/mmu_context.h
> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
>   }
>
>   static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> -		bool write, bool foreign)
> +		bool write, bool execute, bool foreign)
>   {
>   	/* by default, allow everything */
>   	return true;
>

Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

[Xuetao Guan]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain;charset=gb2312, Size: 1614 bytes --]

> ping ... still not upstream.
I'm sorry.
I'll do it in next week.

Xuetao

>
> On 03/21/2016 04:20 AM, Guenter Roeck wrote:
>> unicore32 fails to compile with the following errors.
>>
>> mm/memory.c: In function ‘__handle_mm_fault�:
>> mm/memory.c:3381: error:
>> 	too many arguments to function ‘arch_vma_access_permitted�
>> mm/gup.c: In function ‘check_vma_flags�:
>> mm/gup.c:456: error:
>> 	too many arguments to function ‘arch_vma_access_permitted�
>> mm/gup.c: In function ‘vma_permits_fault�:
>> mm/gup.c:640: error:
>> 	too many arguments to function ‘arch_vma_access_permitted�
>>
>> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction
>> fetches")
>> Cc: Dave Hansen <dave.hansen@linux.intel.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>   arch/unicore32/include/asm/mmu_context.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/unicore32/include/asm/mmu_context.h
>> b/arch/unicore32/include/asm/mmu_context.h
>> index e35632ef23c7..62dfc644c908 100644
>> --- a/arch/unicore32/include/asm/mmu_context.h
>> +++ b/arch/unicore32/include/asm/mmu_context.h
>> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct
>> *mm,
>>   }
>>
>>   static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> -		bool write, bool foreign)
>> +		bool write, bool execute, bool foreign)
>>   {
>>   	/* by default, allow everything */
>>   	return true;
>>
>