From: Laxman Dewangan <ldewangan@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <swarren@wwwdotorg.org>, <linus.walleij@linaro.org>,
<gnurou@gmail.com>, <linux-gpio@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables
Date: Mon, 25 Apr 2016 15:23:22 +0530 [thread overview]
Message-ID: <571DE912.3060602@nvidia.com> (raw)
In-Reply-To: <20160425100055.GA20630@ulmo.ba.sec>
On Monday 25 April 2016 03:30 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Fri, Apr 22, 2016 at 03:39:13PM +0530, Laxman Dewangan wrote:
> [...]
>> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> [...]
>> static struct gpio_chip tegra_gpio_chip = {
> This variable is still file-scoped. Why not get rid of it at the same
> time? It's rather pointless to remove all file-scoped variables except a
> single one, because now the driver still isn't properly equipped to deal
> with multiple instances (however theoretical that may be).
>
Yaah, Alex also pointed that to have the instance of gpio_chip in
tegra_gpio_info and then do as
tgi->gc = tegra_gpio_chip.
same for irq_chip also.
I hope this will resolve the concern.
next prev parent reply other threads:[~2016-04-25 10:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 10:09 [PATCH V4 1/4] gpio: tegra: Don't open code of_device_get_match_data() Laxman Dewangan
2016-04-22 10:09 ` [PATCH V4 2/4] gpio: tegra: Make of_device_id compatible data to constant Laxman Dewangan
2016-04-22 10:09 ` [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables Laxman Dewangan
2016-04-25 5:13 ` Alexandre Courbot
2016-04-25 8:36 ` Laxman Dewangan
2016-04-25 10:00 ` Thierry Reding
2016-04-25 9:53 ` Laxman Dewangan [this message]
2016-04-25 10:11 ` Thierry Reding
2016-04-22 10:09 ` [PATCH V4 4/4] gpio: tegra: Add support for gpio debounce Laxman Dewangan
2016-04-22 19:53 ` Stephen Warren
2016-04-25 5:36 ` Alexandre Courbot
2016-04-25 8:40 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571DE912.3060602@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox