From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154AbcDYK5I (ORCPT ); Mon, 25 Apr 2016 06:57:08 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:60736 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754454AbcDYK5G (ORCPT ); Mon, 25 Apr 2016 06:57:06 -0400 X-AuditID: cbfec7f5-f792a6d000001302-53-571df7fe1ef4 Subject: Re: [PATCH 3/7] mfd: max77686: Use devm_mfd_add_devices and devm_regmap_add_irq_chip To: Laxman Dewangan , lee.jones@linaro.org, milo.kim@ti.com, cw00.choi@samsung.com References: <1461241558-26983-1-git-send-email-ldewangan@nvidia.com> <1461241558-26983-4-git-send-email-ldewangan@nvidia.com> Cc: sbkim73@samsung.com, tony@atomide.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <571DF7FD.8020209@samsung.com> Date: Mon, 25 Apr 2016 12:57:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1461241558-26983-4-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRmVeSWpSXmKPExsVy+t/xK7r/vsuGG/xr1bK4/uU5q8XrF4YW S/etZrG4//Uoo8XlXXPYLGYv6WexmHF+H5PF8l/rWCwurvjCZLH/ipcDl8e3r5NYPO5c28Pm 0dv8js2jb8sqRo/jN7YzeXzeJBfAFsVlk5Kak1mWWqRvl8CV8fr1B/aCo2wVt87PYmlgPMDa xcjJISFgIvH5x2UoW0ziwr31bF2MXBxCAksZJXbOOsYC4TxjlHi35QQLSJWwQLzEpYkL2EBs EYEsiUNTf4N1CwnUS7Ss/QxmMwt0MEo8XMILYrMJGEtsXr6EDWKDnERv9ySwObwCWhIP7u8A i7MIqEqsnfSCHcQWFYiQeDL3JCNEjaDEj8n3wOo5BVwlem6uZ+5i5ACarydx/6IWxCp5ic1r 3jJPYBSchaRjFkLVLCRVCxiZVzGKppYmFxQnpeca6RUn5haX5qXrJefnbmKExMfXHYxLj1kd YhTgYFTi4f3AIhsuxJpYVlyZe4hRgoNZSYQ34BNQiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/M Xe9DhATSE0tSs1NTC1KLYLJMHJxSDYwns8QUrwhNsrrU4fq/bSH/2Q4V9+7zpmpaBkWWjoWs L941Ndu0nhBIer/sxY715f8qvk7fy67unr6Zn+PG5nlrlt6aIMd865lm8+3ow5dmlJ+9nFu5 x3mjot0jo5SEn7klez34J394MFFhmwDP1bmm3YxbyvI+zD7/lM3W9nJZ0Ylr857zK75UYinO SDTUYi4qTgQAtXg8L4sCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/21/2016 02:25 PM, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for adding MFD child devices and > devm_regmap_add_irq_chip() for IRQ chip registration. > > This reduces the error code path and .remove callback for removing > MFD child devices and deleting IRQ chip data. > > Signed-off-by: Laxman Dewangan > CC: Chanwoo Choi > CC: Krzysztof Kozlowski > --- > drivers/mfd/max77686.c | 31 ++++++++----------------------- > 1 file changed, 8 insertions(+), 23 deletions(-) Switching existing code to devm-like interface doesn't bring huge benefits but looks okay and I'm fine with it: Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof