From: David Vrabel <david.vrabel@citrix.com>
To: Thomas Gleixner <tglx@linutronix.de>, Jan Beulich <JBeulich@suse.com>
Cc: <boris.ostrovsky@oracle.com>, Juergen Gross <JGross@suse.com>,
<toshi.kani@hp.com>, <linux-tip-commits@vger.kernel.org>,
<peterz@infradead.org>, <brgerst@gmail.com>,
Luis Rodriguez <Mcgrof@suse.com>, <linux-kernel@vger.kernel.org>,
<luto@amacapital.net>, <vkuznets@redhat.com>,
<dvlasenk@redhat.com>, <bp@alien8.de>, <david.vrabel@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>,
<xen-devel@lists.xenproject.org>, <akpm@linux-foundation.org>,
<torvalds@linux-foundation.org>, <mingo@kernel.org>
Subject: Re: [Xen-devel] [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests
Date: Mon, 25 Apr 2016 13:39:34 +0100 [thread overview]
Message-ID: <571E1006.8080102@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1604250950380.3941@nanos>
On 25/04/16 08:52, Thomas Gleixner wrote:
> On Mon, 25 Apr 2016, Jan Beulich wrote:
>>>>> On 22.04.16 at 20:03, <hpa@zytor.com> wrote:
>>>> +#define hugepages_supported() cpu_has_pse
>>>>
>>>
>>> Please don't use the cpu_has_* macros anymore, they are going away soon.
>>>
>>> In this case it should be static_cpu_has(X86_FEATURE_PSE).
>>
>> I can certainly do that, but this
>> - will (mildly) harm backportability
>> - imo should have been requested much earlier (when the patch was
>> still under discussion)
>
> It's requested now as cpu_has_* is going away. So instead of making silly
> arguments you should have sent a delta patch fixing this.
Ingo fixed this up in the x86/asm branch[1] so I assumed this patch
didn't need updating.
David
[1]
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=x86/asm&id=b2eafe890d4a09bfa63ab31ff018d7d6bb8cfefc
prev parent reply other threads:[~2016-04-25 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 6:27 [PATCH] x86/xen: suppress hugetlbfs in PV guests Jan Beulich
2016-04-22 9:47 ` [tip:x86/asm] x86/mm/xen: Suppress " tip-bot for Jan Beulich
2016-04-22 18:03 ` H. Peter Anvin
2016-04-22 18:16 ` Borislav Petkov
2016-04-25 7:37 ` Jan Beulich
2016-04-25 7:52 ` Thomas Gleixner
2016-04-25 12:39 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E1006.8080102@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=Mcgrof@suse.com \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=toshi.kani@hp.com \
--cc=vkuznets@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox