Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi

David Lechner
2016-04-25T16:26:19Z

On 04/25/2016 08:30 AM, Sekhar Nori wrote:
> Hi David,
>
> On Saturday 16 April 2016 10:30 PM, David Lechner wrote:
>> All other devices are disabled by default and not all boards will use
>> these devices, so these should be disabled too..
>>
>> da850-evm.dtb already had status = "okay" for these devices.
>> da850-enbw-cmc.dts did not, so they were added.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> Tested-by: Kevin Hilman <khilman@baylibre.com>
>
> I applied this and other patches in this series. One nit-pick though.
> The commit description should be independently readable and not only as
> continuation of the headline. Even if this means repeating portion of
> the headline. I fixed this for most of the patches in this series. For
> example, for this patch, I have:
>
> ARM: dts: da850: disable mdio and eth0 in da850.dtsi
>
> Disable mdio and eth0 in da850.dtsi file. All other
> devices are disabled by default and not all boards
> will use these devices, so these should be disabled too.
>
> da850-evm.dtb already had status = "okay" for these devices.
> da850-enbw-cmc.dts did not, so they were added.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> [nsekhar@ti.com: commit description updates]
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>
> Its a minor change and I wont reply to all the patches with the changes
> I made. But I pushed the updated v4.7/dt branch in my tree. Do take a
> look at the commit description there.
>
> Thanks,
> Sekhar
>
>

I had a look at the commits. I'll be sure to follow that advice in the
future.