From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752014AbcDYXCu (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Apr 2016 19:02:50 -0400
Received: from mail-pa0-f49.google.com ([209.85.220.49]:35044 "EHLO
	mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751860AbcDYXCs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Apr 2016 19:02:48 -0400
Subject: Re: [PATCH] soc: brcmstb: select SOC_BUS
To: Arnd Bergmann <arnd@arndb.de>, Brian Norris <computersforpeace@gmail.com>,
        Gregory Fong <gregory.0xf0@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>
References: <1461625017-1939162-1-git-send-email-arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
        bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org
From: Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <571EA18F.2030401@gmail.com>
Date: Mon, 25 Apr 2016 16:00:31 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1461625017-1939162-1-git-send-email-arnd@arndb.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/04/16 15:55, Arnd Bergmann wrote:
> The newly added code for the SoC bus fails to link if the
> bus is not built:
> 
> drivers/soc/built-in.o: In function `brcmstb_soc_device_init':
> :(.init.text+0x110): undefined reference to `soc_device_register'
> 
> This adds a 'select' statement to avoid the error.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Fixes: cef4bafcea2c ("soc: brcmstb: add SoC driver to brcmstb")

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!

> ---
>  drivers/soc/brcmstb/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/brcmstb/Kconfig b/drivers/soc/brcmstb/Kconfig
> index 39cab3b..7fec3b4 100644
> --- a/drivers/soc/brcmstb/Kconfig
> +++ b/drivers/soc/brcmstb/Kconfig
> @@ -1,6 +1,7 @@
>  menuconfig SOC_BRCMSTB
>  	bool "Broadcom STB SoC drivers"
>  	depends on ARM
> +	select SOC_BUS
>  	help
>  	  Enables drivers for the Broadcom Set-Top Box (STB) series of chips.
>  	  This option alone enables only some support code, while the drivers
> 


-- 
Florian