From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752415AbcDYXvl (ORCPT ); Mon, 25 Apr 2016 19:51:41 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:34410 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752355AbcDYXvj (ORCPT ); Mon, 25 Apr 2016 19:51:39 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79b26d0000013da-69-571ead897787 Content-transfer-encoding: 8BIT Message-id: <571EAD88.5000505@samsung.com> Date: Tue, 26 Apr 2016 08:51:36 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lu Baolu , felipe.balbi@linux.intel.com, Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , MyungJoo Ham , Liam Girdwood , Mark Brown Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface References: <1461571496-9600-1-git-send-email-baolu.lu@linux.intel.com> <1461571496-9600-3-git-send-email-baolu.lu@linux.intel.com> In-reply-to: <1461571496-9600-3-git-send-email-baolu.lu@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsWyRsSkQLdzrVy4wa4FAhabJ25ls5j68Amb xfybSRbNi9ezWXSt3slicf/rUUaLb1c6mCwu75rDZrFoWSuzRfOmKawWtxtXsDlwe+ycdZfd Y/Gel0wem1Z1snncubaHzWPeyUCP/XPXsHv0bVnF6PF5k1wARxSXTUpqTmZZapG+XQJXxrST W1gLznNUTL3F38DYwN7FyMkhIWAisXfCJjYIW0ziwr31YLaQwApGiQvfU2Fqth/YytTFyAUU X8oosezoRCaQBK+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmreIGaL+AaPEwXWPmUBqeAW0 JGYe4gCpYRFQlfg/+S0LiM0GFN7/4gYbSImoQIRE94lKkFYRgfdMEq/n9bJBjLeW+LkvH6Rc WCBUovHVOqjxrYwS+1svgM3hFPCQ2HJ/LlhCQqCVQ2JPyyZGiGUCEt8mHwK7U0JAVmLTAWaI vyQlDq64wTKBUWwWkm9mIXwzC8k3CxiZVzGKphYkFxQnpRcZ6RUn5haX5qXrJefnbmIERuzp f8/6djDePGB9iFGAg1GJh1dhmVy4EGtiWXFl7iFGU6AjJjJLiSbnA9NCXkm8obGZkYWpiamx kbmlmZI4b4LUz2AhgfTEktTs1NSC1KL4otKc1OJDjEwcnFINjF0P24QCz4i/7X2oPUNG61/G 7jgrlVsJloUzVzgsDLWtn97w9uB5fY2uW6UChp4VJxc7P850iNQ/wvEk/33sMa6M+0XH/1xq e1Td8WPuhKr0/q+K6bxXqs/vKp2RpHVf0DVt46kTk3ZG73VcuNrvnHZGYqOuio+tnIrsxYP5 85OTHOIZX3+JVGIpzkg01GIuKk4EAKoSFszTAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xgG7nWrlwg8mnuCw2T9zKZjH14RM2 i/k3kyyaF69ns+havZPF4v7Xo4wW3650MFlc3jWHzWLRslZmi+ZNU1gtbjeuYHPg9tg56y67 x+I9L5k8Nq3qZPO4c20Pm8e8k4Ee++euYffo27KK0ePzJrkAjqgGRpuM1MSU1CKF1Lzk/JTM vHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoEOVFMoSc0qBQgGJxcVK+naYJoSG uOlawDRG6PqGBMH1GBmggYQ1jBnTTm5hLTjPUTH1Fn8DYwN7FyMnh4SAicT2A1uZIGwxiQv3 1rN1MXJxCAksZZRYdnQiWIJXQFDix+R7LF2MHBzMAvISRy5lg4SZBdQlJs1bxAxR/4BR4uC6 x0wgNbwCWhIzD3GA1LAIqEr8n/yWBcRmAwrvf3GDDaREVCBCovtEJUiriMB7JonX83rZIMZb S/zclw9SLiwQKtH4ah3U+FZGif2tF8DmcAp4SGy5P5d5AqPALCTXzUK4bhaS6xYwMq9ilEgt SC4oTkrPNcpLLdcrTswtLs1L10vOz93ECE4Lz6R3MB7e5X6IUYCDUYmHt2KFXLgQa2JZcWXu IUYJDmYlEd4HK4FCvCmJlVWpRfnxRaU5qcWHGE2B/pvILCWanA9MWXkl8YbGJmZGlkbmhhZG xuZK4ryP/68LExJITyxJzU5NLUgtgulj4uCUamBMEGco8rr57q/F3BOGlv1LJv93Z/4wrWLt Po83/tyfp6TmeKht/efBNtPm6yYbuesxywIWCac/5/KM3lHwLX/ax2vLxA4ltMpccQzWMZZW /2PDseEnn+Kuj4u0+I9yBHibv9V1C9w8c1b5nxufSp11ov59fn2GTXaC4OYfNm07rF6rBLLm ebkpsRRnJBpqMRcVJwIAOmoLyiEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lu, On 2016년 04월 25일 17:04, Lu Baolu wrote: > GPIO resource could be retrieved through APCI as well. > > Signed-off-by: Lu Baolu > Reviewed-by: Felipe Balbi > Acked-by: Chanwoo Choi > --- > drivers/extcon/extcon-usb-gpio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index af9c8b0..472c431 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > > #define USB_GPIO_DEBOUNCE_MS 20 /* ms */ > > @@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev) > struct usb_extcon_info *info; > int ret; > > - if (!np) > + if (!np && !ACPI_HANDLE(dev)) > return -EINVAL; > > info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); > Applied it. Thanks, Chanwoo Choi