* [PATCH] watchdog: trivial fix of spelling mistake on "allocate"
@ 2016-04-25 19:19 Colin King
2016-04-26 1:41 ` Guenter Roeck
2016-04-26 5:22 ` Joe Perches
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2016-04-25 19:19 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Jiri Kosina, linux-watchdog; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
fix spelling mistake, alloacate -> allocate
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/watchdog/jz4740_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
index 6a7d5c3..3f2ddc8 100644
--- a/drivers/watchdog/jz4740_wdt.c
+++ b/drivers/watchdog/jz4740_wdt.c
@@ -161,7 +161,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata),
GFP_KERNEL);
if (!drvdata) {
- dev_err(&pdev->dev, "Unable to alloacate watchdog device\n");
+ dev_err(&pdev->dev, "Unable to allocate watchdog device\n");
return -ENOMEM;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: trivial fix of spelling mistake on "allocate"
2016-04-25 19:19 [PATCH] watchdog: trivial fix of spelling mistake on "allocate" Colin King
@ 2016-04-26 1:41 ` Guenter Roeck
2016-04-26 5:22 ` Joe Perches
1 sibling, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2016-04-26 1:41 UTC (permalink / raw)
To: Colin King, Wim Van Sebroeck, Jiri Kosina, linux-watchdog; +Cc: linux-kernel
On 04/25/2016 12:19 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> fix spelling mistake, alloacate -> allocate
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/jz4740_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> index 6a7d5c3..3f2ddc8 100644
> --- a/drivers/watchdog/jz4740_wdt.c
> +++ b/drivers/watchdog/jz4740_wdt.c
> @@ -161,7 +161,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
> drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata),
> GFP_KERNEL);
> if (!drvdata) {
> - dev_err(&pdev->dev, "Unable to alloacate watchdog device\n");
> + dev_err(&pdev->dev, "Unable to allocate watchdog device\n");
> return -ENOMEM;
> }
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: trivial fix of spelling mistake on "allocate"
2016-04-25 19:19 [PATCH] watchdog: trivial fix of spelling mistake on "allocate" Colin King
2016-04-26 1:41 ` Guenter Roeck
@ 2016-04-26 5:22 ` Joe Perches
2016-04-26 16:50 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2016-04-26 5:22 UTC (permalink / raw)
To: Colin King, Wim Van Sebroeck, Guenter Roeck, Jiri Kosina,
linux-watchdog
Cc: linux-kernel
On Mon, 2016-04-25 at 20:19 +0100, Colin King wrote:
> fix spelling mistake, alloacate -> allocate
[]
> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
[]
> @@ -161,7 +161,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
> drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata),
> GFP_KERNEL);
> if (!drvdata) {
> - dev_err(&pdev->dev, "Unable to alloacate watchdog device\n");
> + dev_err(&pdev->dev, "Unable to allocate watchdog device\n");
Might as well delete this line instead.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: trivial fix of spelling mistake on "allocate"
2016-04-26 5:22 ` Joe Perches
@ 2016-04-26 16:50 ` Guenter Roeck
2016-04-26 17:19 ` Colin Ian King
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2016-04-26 16:50 UTC (permalink / raw)
To: Joe Perches
Cc: Colin King, Wim Van Sebroeck, Jiri Kosina, linux-watchdog,
linux-kernel
On Mon, Apr 25, 2016 at 10:22:19PM -0700, Joe Perches wrote:
> On Mon, 2016-04-25 at 20:19 +0100, Colin King wrote:
> > fix spelling mistake, alloacate -> allocate
> []
> > diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> []
> > @@ -161,7 +161,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
> > drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata),
> > GFP_KERNEL);
> > if (!drvdata) {
> > - dev_err(&pdev->dev, "Unable to alloacate watchdog device\n");
> > + dev_err(&pdev->dev, "Unable to allocate watchdog device\n");
>
> Might as well delete this line instead.
>
Excellent point.
Colin, please resend and just drop the error message. It is not needed
because an error message is already printed by devm_kzalloc().
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] watchdog: trivial fix of spelling mistake on "allocate"
2016-04-26 16:50 ` Guenter Roeck
@ 2016-04-26 17:19 ` Colin Ian King
0 siblings, 0 replies; 5+ messages in thread
From: Colin Ian King @ 2016-04-26 17:19 UTC (permalink / raw)
To: Guenter Roeck, Joe Perches
Cc: Wim Van Sebroeck, Jiri Kosina, linux-watchdog, linux-kernel
On 26/04/16 17:50, Guenter Roeck wrote:
> On Mon, Apr 25, 2016 at 10:22:19PM -0700, Joe Perches wrote:
>> On Mon, 2016-04-25 at 20:19 +0100, Colin King wrote:
>>> fix spelling mistake, alloacate -> allocate
>> []
>>> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
>> []
>>> @@ -161,7 +161,7 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
>>> drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata),
>>> GFP_KERNEL);
>>> if (!drvdata) {
>>> - dev_err(&pdev->dev, "Unable to alloacate watchdog device\n");
>>> + dev_err(&pdev->dev, "Unable to allocate watchdog device\n");
>>
>> Might as well delete this line instead.
>>
> Excellent point.
>
> Colin, please resend and just drop the error message. It is not needed
> because an error message is already printed by devm_kzalloc().
Will do.
>
> Thanks,
> Guenter
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-26 17:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-25 19:19 [PATCH] watchdog: trivial fix of spelling mistake on "allocate" Colin King
2016-04-26 1:41 ` Guenter Roeck
2016-04-26 5:22 ` Joe Perches
2016-04-26 16:50 ` Guenter Roeck
2016-04-26 17:19 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox