From: Wei Xu <xuwei5@hisilicon.com>
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>,
Jiancheng Xue <jchxue@gmail.com>,
Haifeng Yan <yanhaifeng@gmail.com>,
Olof Johansson <olof@lixom.net>,
Russell King <linux@arm.linux.org.uk>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option
Date: Tue, 26 Apr 2016 09:30:43 +0100 [thread overview]
Message-ID: <571F2733.6070609@hisilicon.com> (raw)
In-Reply-To: <1461590006-1395429-1-git-send-email-arnd@arndb.de>
Hi Arnd,
On 25/04/2016 14:13, Arnd Bergmann wrote:
> DEBUG_HI3716_UART was supposed to be renamed to DEBUG_HIX5HD2_UART, but
> accidentally both got left in place, which results in a build error when
> CONFIG_DEBUG_UART_PHYS is not set as it should be.
>
> This removes the old symbol.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 12aae3097454 ("ARM: debug: Rename Hi3716 to HIX5HD2")
> ---
> arch/arm/Kconfig.debug | 8 --------
> 1 file changed, 8 deletions(-)
Thanks!
Fine to me.
Should I pick up it and send a pull request or
will you directly pick up it?
Best Regards,
Wei
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 6993978cfd6f..2afd38766707 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -268,14 +268,6 @@ choice
> Say Y here if you want kernel low-level debugging support
> on HI3620 UART.
>
> - config DEBUG_HI3716_UART
> - bool "Hisilicon Hi3716 Debug UART"
> - depends on ARCH_HI3xxx
> - select DEBUG_UART_PL01X
> - help
> - Say Y here if you want kernel low-level debugging support
> - on HI3716 UART.
> -
> config DEBUG_HIGHBANK_UART
> bool "Kernel low-level debugging messages via Highbank UART"
> depends on ARCH_HIGHBANK
>
next prev parent reply other threads:[~2016-04-26 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:13 [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option Arnd Bergmann
2016-04-26 8:30 ` Wei Xu [this message]
2016-04-26 11:01 ` Arnd Bergmann
2016-04-26 17:10 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571F2733.6070609@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=arnd@arndb.de \
--cc=haojian.zhuang@linaro.org \
--cc=jchxue@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=yanhaifeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox