From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbcDZIcz (ORCPT ); Tue, 26 Apr 2016 04:32:55 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:33888 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbcDZIcx (ORCPT ); Tue, 26 Apr 2016 04:32:53 -0400 Subject: Re: [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option To: Arnd Bergmann , References: <1461590006-1395429-1-git-send-email-arnd@arndb.de> CC: Haojian Zhuang , Jiancheng Xue , Haifeng Yan , Olof Johansson , Russell King , From: Wei Xu Message-ID: <571F2733.6070609@hisilicon.com> Date: Tue, 26 Apr 2016 09:30:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461590006-1395429-1-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.153] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.571F274A.010C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e6bade7c755753bc16af20465b0842a7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 25/04/2016 14:13, Arnd Bergmann wrote: > DEBUG_HI3716_UART was supposed to be renamed to DEBUG_HIX5HD2_UART, but > accidentally both got left in place, which results in a build error when > CONFIG_DEBUG_UART_PHYS is not set as it should be. > > This removes the old symbol. > > Signed-off-by: Arnd Bergmann > Fixes: 12aae3097454 ("ARM: debug: Rename Hi3716 to HIX5HD2") > --- > arch/arm/Kconfig.debug | 8 -------- > 1 file changed, 8 deletions(-) Thanks! Fine to me. Should I pick up it and send a pull request or will you directly pick up it? Best Regards, Wei > > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index 6993978cfd6f..2afd38766707 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -268,14 +268,6 @@ choice > Say Y here if you want kernel low-level debugging support > on HI3620 UART. > > - config DEBUG_HI3716_UART > - bool "Hisilicon Hi3716 Debug UART" > - depends on ARCH_HI3xxx > - select DEBUG_UART_PL01X > - help > - Say Y here if you want kernel low-level debugging support > - on HI3716 UART. > - > config DEBUG_HIGHBANK_UART > bool "Kernel low-level debugging messages via Highbank UART" > depends on ARCH_HIGHBANK >