* [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option
@ 2016-04-25 13:13 Arnd Bergmann
2016-04-26 8:30 ` Wei Xu
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2016-04-25 13:13 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wei Xu, Haojian Zhuang, Jiancheng Xue, Haifeng Yan,
Olof Johansson, Arnd Bergmann, Russell King, linux-kernel
DEBUG_HI3716_UART was supposed to be renamed to DEBUG_HIX5HD2_UART, but
accidentally both got left in place, which results in a build error when
CONFIG_DEBUG_UART_PHYS is not set as it should be.
This removes the old symbol.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 12aae3097454 ("ARM: debug: Rename Hi3716 to HIX5HD2")
---
arch/arm/Kconfig.debug | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 6993978cfd6f..2afd38766707 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -268,14 +268,6 @@ choice
Say Y here if you want kernel low-level debugging support
on HI3620 UART.
- config DEBUG_HI3716_UART
- bool "Hisilicon Hi3716 Debug UART"
- depends on ARCH_HI3xxx
- select DEBUG_UART_PL01X
- help
- Say Y here if you want kernel low-level debugging support
- on HI3716 UART.
-
config DEBUG_HIGHBANK_UART
bool "Kernel low-level debugging messages via Highbank UART"
depends on ARCH_HIGHBANK
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option
2016-04-25 13:13 [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option Arnd Bergmann
@ 2016-04-26 8:30 ` Wei Xu
2016-04-26 11:01 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Wei Xu @ 2016-04-26 8:30 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel
Cc: Haojian Zhuang, Jiancheng Xue, Haifeng Yan, Olof Johansson,
Russell King, linux-kernel
Hi Arnd,
On 25/04/2016 14:13, Arnd Bergmann wrote:
> DEBUG_HI3716_UART was supposed to be renamed to DEBUG_HIX5HD2_UART, but
> accidentally both got left in place, which results in a build error when
> CONFIG_DEBUG_UART_PHYS is not set as it should be.
>
> This removes the old symbol.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 12aae3097454 ("ARM: debug: Rename Hi3716 to HIX5HD2")
> ---
> arch/arm/Kconfig.debug | 8 --------
> 1 file changed, 8 deletions(-)
Thanks!
Fine to me.
Should I pick up it and send a pull request or
will you directly pick up it?
Best Regards,
Wei
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 6993978cfd6f..2afd38766707 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -268,14 +268,6 @@ choice
> Say Y here if you want kernel low-level debugging support
> on HI3620 UART.
>
> - config DEBUG_HI3716_UART
> - bool "Hisilicon Hi3716 Debug UART"
> - depends on ARCH_HI3xxx
> - select DEBUG_UART_PL01X
> - help
> - Say Y here if you want kernel low-level debugging support
> - on HI3716 UART.
> -
> config DEBUG_HIGHBANK_UART
> bool "Kernel low-level debugging messages via Highbank UART"
> depends on ARCH_HIGHBANK
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option
2016-04-26 8:30 ` Wei Xu
@ 2016-04-26 11:01 ` Arnd Bergmann
2016-04-26 17:10 ` Wei Xu
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2016-04-26 11:01 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wei Xu, Russell King, linux-kernel, Jiancheng Xue, Haojian Zhuang,
Haifeng Yan, Olof Johansson
On Tuesday 26 April 2016 09:30:43 Wei Xu wrote:
> Hi Arnd,
>
> On 25/04/2016 14:13, Arnd Bergmann wrote:
> > DEBUG_HI3716_UART was supposed to be renamed to DEBUG_HIX5HD2_UART, but
> > accidentally both got left in place, which results in a build error when
> > CONFIG_DEBUG_UART_PHYS is not set as it should be.
> >
> > This removes the old symbol.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 12aae3097454 ("ARM: debug: Rename Hi3716 to HIX5HD2")
> > ---
> > arch/arm/Kconfig.debug | 8 --------
> > 1 file changed, 8 deletions(-)
>
> Thanks!
> Fine to me.
> Should I pick up it and send a pull request or
> will you directly pick up it?
I have put it into the next/cleanup branch now, and added your
Acked-by: Wei Xu <xuwei5@hisilicon.com>
Thanks,
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option
2016-04-26 11:01 ` Arnd Bergmann
@ 2016-04-26 17:10 ` Wei Xu
0 siblings, 0 replies; 4+ messages in thread
From: Wei Xu @ 2016-04-26 17:10 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel
Cc: Russell King, linux-kernel, Jiancheng Xue, Haojian Zhuang,
Haifeng Yan, Olof Johansson
Hi Arnd,
On 26/04/2016 12:01, Arnd Bergmann wrote:
> On Tuesday 26 April 2016 09:30:43 Wei Xu wrote:
>> Hi Arnd,
>>
>> On 25/04/2016 14:13, Arnd Bergmann wrote:
>>> DEBUG_HI3716_UART was supposed to be renamed to DEBUG_HIX5HD2_UART, but
>>> accidentally both got left in place, which results in a build error when
>>> CONFIG_DEBUG_UART_PHYS is not set as it should be.
>>>
>>> This removes the old symbol.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> Fixes: 12aae3097454 ("ARM: debug: Rename Hi3716 to HIX5HD2")
>>> ---
>>> arch/arm/Kconfig.debug | 8 --------
>>> 1 file changed, 8 deletions(-)
>>
>> Thanks!
>> Fine to me.
>> Should I pick up it and send a pull request or
>> will you directly pick up it?
>
> I have put it into the next/cleanup branch now, and added your
>
> Acked-by: Wei Xu <xuwei5@hisilicon.com>
Thanks!
Best Regards,
Wei
>
> Thanks,
>
> Arnd
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-26 17:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-25 13:13 [PATCH] ARM: debug: remove extraneous DEBUG_HI3716_UART option Arnd Bergmann
2016-04-26 8:30 ` Wei Xu
2016-04-26 11:01 ` Arnd Bergmann
2016-04-26 17:10 ` Wei Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox