From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbcD0Bla (ORCPT ); Tue, 26 Apr 2016 21:41:30 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:42204 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752327AbcD0Bl2 (ORCPT ); Tue, 26 Apr 2016 21:41:28 -0400 Subject: Re: [PATCH] watchdog: remove error message when unable to allocate watchdog device To: Colin King , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org References: <1461691129-4764-1-git-send-email-colin.king@canonical.com> From: Guenter Roeck Message-ID: <572018C5.9020403@roeck-us.net> Date: Tue, 26 Apr 2016 18:41:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461691129-4764-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/2016 10:18 AM, Colin King wrote: > From: Colin Ian King > > The dev_err message is superfluous because the failure is already > printed by dev_kzalloc, so remove it. > Nitpick: devm_kzalloc > Signed-off-by: Colin Ian King Reviewed-by: Guenter Roeck Thanks, Guenter > --- > drivers/watchdog/jz4740_wdt.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c > index 6a7d5c3..c8d51dd 100644 > --- a/drivers/watchdog/jz4740_wdt.c > +++ b/drivers/watchdog/jz4740_wdt.c > @@ -160,10 +160,8 @@ static int jz4740_wdt_probe(struct platform_device *pdev) > > drvdata = devm_kzalloc(&pdev->dev, sizeof(struct jz4740_wdt_drvdata), > GFP_KERNEL); > - if (!drvdata) { > - dev_err(&pdev->dev, "Unable to alloacate watchdog device\n"); > + if (!drvdata) > return -ENOMEM; > - } > > if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT) > heartbeat = DEFAULT_HEARTBEAT; >