From: Jaehoon Chung <jh80.chung@samsung.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards.
Date: Wed, 27 Apr 2016 17:35:10 +0900 [thread overview]
Message-ID: <572079BE.9000006@samsung.com> (raw)
In-Reply-To: <1461657838-25484-1-git-send-email-enric.balletbo@collabora.com>
On 04/26/2016 05:03 PM, Enric Balletbo i Serra wrote:
> Hi,
>
> I introduced the cover letter to give some background about this.
>
> I have been investigating a problem related to at least one specific sdcard when
> UHS-I is set. The card is not detected due the tuning phase reports a
> failure. Since the problem is only reproduced with a single model of a single
> brand of card, it is probably a card firmware issue, but the card works fine
> on my laptop.
I think you have analyzed many case..of course..it was successful to switch voltage, right?
Maybe this patch too old..so can you remember which specific sdcard is produced?
>
> The first attempt to fix this was a patch sent by Doug Anderson [1], but Alim
> Akhtar found that this produced randomly a hung task on Peach-pi. I can confirm
> that it's easy to reproduce the hung task, either, with cold boots or suspend to
> ram tests.
Yep..I have already tested and checked for this.
>
> I tried to fix both problems (the original issue and the one introduced by the
> patch) in different ways, but I ended thinking that this second proposal is the
> most simple that solves both issues. So let's try to fix this by handling the
> response CRC error slightly differently when tuning command is happening.
>
> I tested the patch on both platforms, on exynos and on rockhip. I did lots of
> tests and at the moment the patch seems to fix the rockchip issue and don't
> hung on exynos. I'll continue testing meanwhile we discuss about it.
>
> I think the patch, at least, needs the Doug's approval (as he dig into the issue
> before) and the Tested-by Alim. So will be good if you have a slot of time to
> look a bit into this.
>
> Thanks in advance.
> Enric
>
> [1] https://lkml.org/lkml/2015/5/18/495
>
> Changelog since v1:
> - Fix the issue found by Alim with exynos letting the data transfer
> take place only when MMC_SEND_TUNING_BLOCK is issued.
>
> Doug Anderson (1):
> mmc: dw_mmc: Wait for data transfer after response errors.
>
> drivers/mmc/host/dw_mmc.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
next prev parent reply other threads:[~2016-04-27 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 8:03 [RESEND PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards Enric Balletbo i Serra
2016-04-26 8:03 ` [RESEND PATCH v2 1/1] mmc: dw_mmc: Wait for data transfer after response errors Enric Balletbo i Serra
2016-06-20 10:14 ` Jaehoon Chung
2016-06-21 16:30 ` Enric Balletbo Serra
2016-06-22 1:26 ` Jaehoon Chung
2016-04-27 8:35 ` Jaehoon Chung [this message]
2016-04-27 8:53 ` [RESEND PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards Enric Balletbo i Serra
2016-06-20 7:59 ` Enric Balletbo Serra
2016-06-20 8:02 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572079BE.9000006@samsung.com \
--to=jh80.chung@samsung.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox